third_party/WebKit/Source/core/loader/EmptyClients.h - Issue 2103733004: Set navigationStart correctly for all load types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add more tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/EmptyClients.h

diff --git a/third_party/WebKit/Source/core/loader/EmptyClients.h b/third_party/WebKit/Source/core/loader/EmptyClients.h

index 72b4525e127bc526271215ed5030ce6d55328d8d..de71ade6d53b701c415fed0d6569d3ae017017d8 100644

--- a/third_party/WebKit/Source/core/loader/EmptyClients.h

+++ b/third_party/WebKit/Source/core/loader/EmptyClients.h

@@ -209,6 +209,7 @@ public:

void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const ResourceResponse&) override {}

void dispatchDidHandleOnloadEvents() override {}

+ void dispatchDidHandleOnBeforeUnloadEvent(bool eventListenerCalled) override {}

void dispatchDidReceiveServerRedirectForProvisionalLoad() override {}

void dispatchWillClose() override {}

void dispatchDidStartProvisionalLoad(double triggeringEventTime) override {}