third_party/WebKit/Source/core/dom/Document.cpp - Issue 2103733004: Set navigationStart correctly for all load types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add more tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index db999f3fc3671d960408fe3438955f4e2e4c766f..b8a1e14bc921070466db67eafebf11d558ff6017 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -2655,7 +2655,7 @@ void Document::implicitClose()

accessSVGExtensions().startAnimations();

}

-bool Document::dispatchBeforeUnloadEvent(ChromeClient& chromeClient, bool isReload, bool& didAllowNavigation)

+bool Document::dispatchBeforeUnloadEvent(ChromeClient& chromeClient, bool isReload, bool& didAllowNavigation, bool& eventListenerCalled)

{

if (!m_domWindow)

return true;

@@ -2666,6 +2666,8 @@ bool Document::dispatchBeforeUnloadEvent(ChromeClient& chromeClient, bool isRelo

if (processingBeforeUnload())

return false;

+ if (m_domWindow->hasEventListeners(EventTypeNames::beforeunload))

+ eventListenerCalled = true;

BeforeUnloadEvent* beforeUnloadEvent = BeforeUnloadEvent::create();

m_loadEventProgress = BeforeUnloadEventInProgress;

m_domWindow->dispatchEvent(beforeUnloadEvent, this);