third_party/WebKit/Source/core/loader/EmptyClients.h - Issue 2103733004: Set navigationStart correctly for all load types.

Side by Side Diff: third_party/WebKit/Source/core/loader/EmptyClients.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add more tests. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/renderer/render_view_browsertest.cc ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)	2 * Copyright (C) 2006 Eric Seidel (eric@webkit.org)

3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.	3 * Copyright (C) 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.

4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).	4 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).

5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.	5 * Copyright (C) 2012 Samsung Electronics. All rights reserved.

6 *	6 *

7 * Redistribution and use in source and binary forms, with or without	7 * Redistribution and use in source and binary forms, with or without

8 * modification, are permitted provided that the following conditions	8 * modification, are permitted provided that the following conditions

9 * are met:	9 * are met:

10 * 1. Redistributions of source code must retain the above copyright	10 * 1. Redistributions of source code must retain the above copyright

(...skipping 191 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
202 void willBeDetached() override {}	202 void willBeDetached() override {}

203 void detached(FrameDetachType) override {}	203 void detached(FrameDetachType) override {}

204 void frameFocused() const override {}	204 void frameFocused() const override {}

205	205

206 void dispatchWillSendRequest(DocumentLoader*, unsigned long, ResourceRequest &, const ResourceResponse&) override {}	206 void dispatchWillSendRequest(DocumentLoader*, unsigned long, ResourceRequest &, const ResourceResponse&) override {}

207 void dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const Resour ceResponse&) override {}	207 void dispatchDidReceiveResponse(DocumentLoader*, unsigned long, const Resour ceResponse&) override {}

208 void dispatchDidFinishLoading(DocumentLoader*, unsigned long) override {}	208 void dispatchDidFinishLoading(DocumentLoader*, unsigned long) override {}

209 void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const Re sourceResponse&) override {}	209 void dispatchDidLoadResourceFromMemoryCache(const ResourceRequest&, const Re sourceResponse&) override {}

210	210

211 void dispatchDidHandleOnloadEvents() override {}	211 void dispatchDidHandleOnloadEvents() override {}

	212 void dispatchDidHandleOnBeforeUnloadEvent(bool eventListenerCalled) override {}

212 void dispatchDidReceiveServerRedirectForProvisionalLoad() override {}	213 void dispatchDidReceiveServerRedirectForProvisionalLoad() override {}

213 void dispatchWillClose() override {}	214 void dispatchWillClose() override {}

214 void dispatchDidStartProvisionalLoad(double triggeringEventTime) override {}	215 void dispatchDidStartProvisionalLoad(double triggeringEventTime) override {}

215 void dispatchDidReceiveTitle(const String&) override {}	216 void dispatchDidReceiveTitle(const String&) override {}

216 void dispatchDidChangeIcons(IconType) override {}	217 void dispatchDidChangeIcons(IconType) override {}

217 void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override {}	218 void dispatchDidCommitLoad(HistoryItem*, HistoryCommitType) override {}

218 void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override {}	219 void dispatchDidFailProvisionalLoad(const ResourceError&, HistoryCommitType) override {}

219 void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override { }	220 void dispatchDidFailLoad(const ResourceError&, HistoryCommitType) override { }

220 void dispatchDidFinishDocumentLoad() override {}	221 void dispatchDidFinishDocumentLoad() override {}

221 void dispatchDidFinishLoad() override {}	222 void dispatchDidFinishLoad() override {}

(...skipping 107 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
329 ~EmptyContextMenuClient() override {}	330 ~EmptyContextMenuClient() override {}

330 bool showContextMenu(const ContextMenu*, bool) override { return false; }	331 bool showContextMenu(const ContextMenu*, bool) override { return false; }

331 void clearContextMenu() override {}	332 void clearContextMenu() override {}

332 };	333 };

333	334

334 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);	335 CORE_EXPORT void fillWithEmptyClients(Page::PageClients&);

335	336

336 } // namespace blink	337 } // namespace blink

337	338

338 #endif // EmptyClients_h	339 #endif // EmptyClients_h

OLD	NEW