third_party/WebKit/Source/core/dom/Document.h - Issue 2103733004: Set navigationStart correctly for all load types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.h

Issue 2103733004: Set navigationStart correctly for all load types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments, add more tests. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Document.h

diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h

index 07a9c5bce06ebd3472b29b08114ffaf403ca3305..c1386f0af4d8a343dcf05a135a68b2cfaf627503 100644

--- a/third_party/WebKit/Source/core/dom/Document.h

+++ b/third_party/WebKit/Source/core/dom/Document.h

@@ -497,7 +497,7 @@ public:

// implicitClose() actually does the work of closing the input stream.

void implicitClose();

- bool dispatchBeforeUnloadEvent(ChromeClient&, bool isReload, bool& didAllowNavigation);

+ bool dispatchBeforeUnloadEvent(ChromeClient&, bool isReload, bool& didAllowNavigation, bool& eventListenerCalled);

void dispatchUnloadEvents();

enum PageDismissalType {