Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2103713003:
[ia32] Fixes a bug in cmpw. (Closed)
|
Created:
4 years, 5 months ago by epertoso Modified:
4 years, 5 months ago Reviewers:
Benedikt Meurer CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[ia32] Fixes a bug in cmpw.
The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed.
Adds a regression test.
BUG=621926
Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0
Committed: https://crrev.com/588e15c0343ba3052b15887f08a84bcd03f7e233
Cr-Original-Commit-Position: refs/heads/master@{#37339}
Cr-Commit-Position: refs/heads/master@{#37345}
Patch Set 1 #Patch Set 2 : Update #Patch Set 3 : Should have fixed v8_mac_rel_ng_triggered. #Patch Set 4 : Save and restore ebx. #
Messages
Total messages: 28 (12 generated)
The CQ bit was checked by epertoso@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
epertoso@chromium.org changed reviewers: + bmeurer@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/3993) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by epertoso@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2103713003/#ps20001 (title: "Update")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/4038) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)
The CQ bit was checked by epertoso@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2103713003/#ps40001 (title: "Should have fixed v8_mac_rel_ng_triggered.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [ia32] Fixes a bug in cmpw. The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG=621926 ========== to ========== [ia32] Fixes a bug in cmpw. The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG=621926 Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 Cr-Commit-Position: refs/heads/master@{#37339} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 Cr-Commit-Position: refs/heads/master@{#37339}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2106913002/ by epertoso@chromium.org. The reason for reverting is: Causes "buildbot failure in V8 on V8 Linux gcc 4.8, Check".
The CQ bit was checked by epertoso@chromium.org
Trying to re-land. Saving and restoring ebx now.
The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org Link to the patchset: https://codereview.chromium.org/2103713003/#ps60001 (title: "Save and restore ebx.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [ia32] Fixes a bug in cmpw. The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG=621926 Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 Cr-Commit-Position: refs/heads/master@{#37339} ========== to ========== [ia32] Fixes a bug in cmpw. The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. Adds a regression test. BUG=621926 Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 Committed: https://crrev.com/588e15c0343ba3052b15887f08a84bcd03f7e233 Cr-Original-Commit-Position: refs/heads/master@{#37339} Cr-Commit-Position: refs/heads/master@{#37345} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/588e15c0343ba3052b15887f08a84bcd03f7e233 Cr-Commit-Position: refs/heads/master@{#37345}
Message was sent while issue was closed.
Note there was one more flake on that bot after your reland: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds... It is turbofan only. Is it still connected to your CL?
Message was sent while issue was closed.
On 2016/06/29 at 06:37:52, machenbach wrote: > Note there was one more flake on that bot after your reland: > https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds... > > It is turbofan only. Is it still connected to your CL? FYI: http://crrev.com/2111503002 (╯°□°)╯︵ ┻━┻ |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
