Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: src/ia32/assembler-ia32.cc

Issue 2103713003: [ia32] Fixes a bug in cmpw. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Save and restore ebx. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ia32/disasm-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 834 matching lines...) Expand 10 before | Expand all | Expand 10 after
845 EnsureSpace ensure_space(this); 845 EnsureSpace ensure_space(this);
846 EMIT(0x66); 846 EMIT(0x66);
847 EMIT(0x81); 847 EMIT(0x81);
848 emit_operand(edi, op); 848 emit_operand(edi, op);
849 emit_w(imm16); 849 emit_w(imm16);
850 } 850 }
851 851
852 void Assembler::cmpw(Register reg, const Operand& op) { 852 void Assembler::cmpw(Register reg, const Operand& op) {
853 EnsureSpace ensure_space(this); 853 EnsureSpace ensure_space(this);
854 EMIT(0x66); 854 EMIT(0x66);
855 EMIT(0x3B);
856 emit_operand(reg, op);
857 }
858
859 void Assembler::cmpw(const Operand& op, Register reg) {
860 EnsureSpace ensure_space(this);
861 EMIT(0x66);
855 EMIT(0x39); 862 EMIT(0x39);
856 emit_operand(reg, op); 863 emit_operand(reg, op);
857 } 864 }
858 865
859 void Assembler::cmpw(const Operand& op, Register reg) {
860 EnsureSpace ensure_space(this);
861 EMIT(0x66);
862 EMIT(0x3B);
863 emit_operand(reg, op);
864 }
865
866 void Assembler::cmp(Register reg, int32_t imm32) { 866 void Assembler::cmp(Register reg, int32_t imm32) {
867 EnsureSpace ensure_space(this); 867 EnsureSpace ensure_space(this);
868 emit_arith(7, Operand(reg), Immediate(imm32)); 868 emit_arith(7, Operand(reg), Immediate(imm32));
869 } 869 }
870 870
871 871
872 void Assembler::cmp(Register reg, Handle<Object> handle) { 872 void Assembler::cmp(Register reg, Handle<Object> handle) {
873 EnsureSpace ensure_space(this); 873 EnsureSpace ensure_space(this);
874 emit_arith(7, Operand(reg), Immediate(handle)); 874 emit_arith(7, Operand(reg), Immediate(handle));
875 } 875 }
(...skipping 2198 matching lines...) Expand 10 before | Expand all | Expand 10 after
3074 fflush(coverage_log); 3074 fflush(coverage_log);
3075 } 3075 }
3076 } 3076 }
3077 3077
3078 #endif 3078 #endif
3079 3079
3080 } // namespace internal 3080 } // namespace internal
3081 } // namespace v8 3081 } // namespace v8
3082 3082
3083 #endif // V8_TARGET_ARCH_IA32 3083 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « no previous file | src/ia32/disasm-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698