Declare onFinish event handler for AnimationPlayer

Declare onFinish event handler for AnimationPlayer.

Finish events occur when a sample occurs that causes a player to be newly limited or newly disassociated with a timeline. 
(From section 3.5.4 Player events 
http://dev.w3.org/fxtf/web-animations/#player-events
and section 5.19 The AnimationPlayerEvent interface
http://dev.w3.org/fxtf/web-animations/#the-animationplayerevent-interface )

Subsequent CL 216203003 dispatches the events declared here.

BUG=356120
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170518

[Eric Willigers, 2014-03-30 23:00:32]

+alancutter

[alancutter (OOO until 2018), 2014-03-31 06:28:13]

lgtm

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/D...
File Source/core/animation/DocumentTimeline.cpp (right):

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/D...
Source/core/animation/DocumentTimeline.cpp:73: RefPtr<AnimationPlayer> player =
AnimationPlayer::create(m_document ? m_document->contextDocument().get() : 0,
*this, child);
Ideally a JS handle to DocumentTimeline would keep Document alive and this check
for null would not be needed. Perhaps we should have an exit if null check in
play() with a FIXME for now to make intended behaviour more clear.

https://codereview.chromium.org/210363007/diff/170001/Source/core/events/Anim...
File Source/core/events/AnimationPlayerEvent.cpp (right):

https://codereview.chromium.org/210363007/diff/170001/Source/core/events/Anim...
Source/core/events/AnimationPlayerEvent.cpp:8: #include
"core/events/ThreadLocalEventNames.h"
Unnecessary include.

[dstockwell, 2014-03-31 06:32:53]

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/A...
File Source/core/animation/AnimationPlayer.h (right):

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/A...
Source/core/animation/AnimationPlayer.h:44: class AnimationPlayer FINAL : public
RefCounted<AnimationPlayer>, public EventTargetWithInlineData, public
ActiveDOMObject {
Why does AnimationPlayer become an ActiveDOMObject?

[Eric Willigers, 2014-03-31 08:48:46]

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/A...
File Source/core/animation/AnimationPlayer.h (right):

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/A...
Source/core/animation/AnimationPlayer.h:44: class AnimationPlayer FINAL : public
RefCounted<AnimationPlayer>, public EventTargetWithInlineData, public
ActiveDOMObject {
On 2014/03/31 06:32:53, dstockwell wrote:
> Why does AnimationPlayer become an ActiveDOMObject?

Changed to use ContextLifecycleObserver.

As an event target, we need to provide the executionContext, and
ContextLifecycleObserver stores it.

The majority of event targets inherit from ContextLifecycleObserver, directly or
through ActiveDOMObject.

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/D...
File Source/core/animation/DocumentTimeline.cpp (right):

https://codereview.chromium.org/210363007/diff/170001/Source/core/animation/D...
Source/core/animation/DocumentTimeline.cpp:73: RefPtr<AnimationPlayer> player =
AnimationPlayer::create(m_document ? m_document->contextDocument().get() : 0,
*this, child);
On 2014/03/31 06:28:13, alancutter wrote:
> Ideally a JS handle to DocumentTimeline would keep Document alive and this
check
> for null would not be needed. Perhaps we should have an exit if null check in
> play() with a FIXME for now to make intended behaviour more clear.

Done.

https://codereview.chromium.org/210363007/diff/170001/Source/core/events/Anim...
File Source/core/events/AnimationPlayerEvent.cpp (right):

https://codereview.chromium.org/210363007/diff/170001/Source/core/events/Anim...
Source/core/events/AnimationPlayerEvent.cpp:8: #include
"core/events/ThreadLocalEventNames.h"
On 2014/03/31 06:28:13, alancutter wrote:
> Unnecessary include.

Done.

[dstockwell, 2014-03-31 09:17:23]

https://codereview.chromium.org/210363007/diff/230001/Source/core/animation/A...
File Source/core/animation/AnimationPlayer.cpp (right):

https://codereview.chromium.org/210363007/diff/230001/Source/core/animation/A...
Source/core/animation/AnimationPlayer.cpp:249: return
ContextLifecycleObserver::executionContext();
Isn't the timeline's document the execution context? What do we get by storing
it in a ContextLifecycleObserver?

[Eric Willigers, 2014-04-01 01:15:54]

+haraken

[Eric Willigers, 2014-04-01 05:05:48]

haraken - Can I please have an OWNERS review for AnimationPlayerEvent.

https://codereview.chromium.org/210363007/diff/230001/Source/core/animation/A...
File Source/core/animation/AnimationPlayer.cpp (right):

https://codereview.chromium.org/210363007/diff/230001/Source/core/animation/A...
Source/core/animation/AnimationPlayer.cpp:249: return
ContextLifecycleObserver::executionContext();
On 2014/03/31 09:17:24, dstockwell wrote:
> Isn't the timeline's document the execution context? What do we get by storing
> it in a ContextLifecycleObserver?

The execution context is document.contextDocument()

We don't need ContextLifecycleObserver. Now removed.

[haraken, 2014-04-01 05:08:55]

On 2014/04/01 05:05:48, Eric Willigers wrote:
> haraken - Can I please have an OWNERS review for AnimationPlayerEvent.

LGTM for AnimationPlayerEvent (in terms of oilpan).

[dstockwell, 2014-04-01 05:19:57]

lgtm

[commit-bot: I haz the power, 2014-04-01 05:20:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/210363007/2...

[commit-bot: I haz the power, 2014-04-01 06:27:37]

Change committed as 170518