Source/core/animation/DocumentTimeline.cpp - Issue 210363007: Declare onFinish event handler for AnimationPlayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DocumentTimeline.cpp

Issue 210363007: Declare onFinish event handler for AnimationPlayer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Stop using ContextLifecycleObserver Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/DocumentTimeline.cpp

diff --git a/Source/core/animation/DocumentTimeline.cpp b/Source/core/animation/DocumentTimeline.cpp

index 77ef592d566ff005da38639a7d62257444a653db..9e862d5d959c895853826de18802d239fa4461b3 100644

--- a/Source/core/animation/DocumentTimeline.cpp

+++ b/Source/core/animation/DocumentTimeline.cpp

@@ -79,6 +79,8 @@ AnimationPlayer* DocumentTimeline::createAnimationPlayer(TimedItem* child)

AnimationPlayer* DocumentTimeline::play(TimedItem* child)

{

+ if (!m_document)

+ return 0;

AnimationPlayer* player = createAnimationPlayer(child);

player->setStartTime(effectiveTime());

return player;

@@ -190,6 +192,7 @@ size_t DocumentTimeline::numberOfActiveAnimationsForTesting() const

}

void DocumentTimeline::detachFromDocument() {

+ // FIXME: DocumentTimeline should keep Document alive.

m_document = 0;

}

« no previous file with comments | « Source/core/animation/DocumentTimeline.h ('k') | Source/core/core.gypi » ('j') | no next file with comments »