Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2103363004: [turbofan] Run representation selection without the Typer decorator. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Run representation selection without the Typer decorator. It's not safe to magically compute types during representation selection, so better disable the Typer decorator before we start to do the representation/truncation analysis. This will also allow us to move to a world where we can run representation selection concurrently eventually. R=jarin@chromium.org Committed: https://crrev.com/85c9f0018ac5b671973b916a85692cec2a0c6d3d Cr-Commit-Position: refs/heads/master@{#37367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 6 chunks +16 lines, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-29 07:38:57 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-06-29 07:39:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103363004/1
4 years, 5 months ago (2016-06-29 07:41:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 08:17:30 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 08:18:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85c9f0018ac5b671973b916a85692cec2a0c6d3d
Cr-Commit-Position: refs/heads/master@{#37367}

Powered by Google App Engine
This is Rietveld 408576698