Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Issue 2107783004: [turbofan] Disallow typing for change/checked operators. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_RepresentationSelection_Typer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disallow typing for change/checked operators. There are no useful typing rules for Change and Checked operators, so we better make sure we don't run them through the Typer at all. R=jarin@chromium.org Committed: https://crrev.com/6f920d7d59915e970a7d09bb6596605015c3bedd Cr-Commit-Position: refs/heads/master@{#37382}

Patch Set 1 #

Patch Set 2 : ReferenceEqual foo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -192 lines) Patch
M src/compiler/js-typed-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 4 chunks +29 lines, -20 lines 0 comments Download
M src/compiler/simplified-operator-reducer.h View 2 chunks +0 lines, -5 lines 0 comments Download
M src/compiler/simplified-operator-reducer.cc View 1 2 chunks +4 lines, -30 lines 0 comments Download
M src/compiler/typer.cc View 8 chunks +14 lines, -128 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 7 chunks +15 lines, -7 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-29 08:34:32 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the followup cleanup and protection against self-healingness. Please take a look. Thanks, ...
4 years, 5 months ago (2016-06-29 08:43:15 UTC) #2
Jarin
lgtm
4 years, 5 months ago (2016-06-29 08:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107783004/1
4 years, 5 months ago (2016-06-29 08:49:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/4127) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 5 months ago (2016-06-29 09:23:31 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107783004/1
4 years, 5 months ago (2016-06-29 09:46:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2107783004/20001
4 years, 5 months ago (2016-06-29 09:48:51 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 10:29:45 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 10:32:28 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f920d7d59915e970a7d09bb6596605015c3bedd
Cr-Commit-Position: refs/heads/master@{#37382}

Powered by Google App Engine
This is Rietveld 408576698