Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Side by Side Diff: src/compiler/pipeline.cc

Issue 2103363004: [turbofan] Run representation selection without the Typer decorator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/pipeline.h" 5 #include "src/compiler/pipeline.h"
6 6
7 #include <fstream> // NOLINT(readability/streams) 7 #include <fstream> // NOLINT(readability/streams)
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/base/adapters.h" 10 #include "src/base/adapters.h"
(...skipping 1426 matching lines...) Expand 10 before | Expand all | Expand 10 after
1437 1437
1438 if (FLAG_turbo_stress_loop_peeling) { 1438 if (FLAG_turbo_stress_loop_peeling) {
1439 Run<StressLoopPeelingPhase>(); 1439 Run<StressLoopPeelingPhase>();
1440 RunPrintAndVerify("Loop peeled"); 1440 RunPrintAndVerify("Loop peeled");
1441 } 1441 }
1442 1442
1443 if (FLAG_turbo_escape) { 1443 if (FLAG_turbo_escape) {
1444 Run<EscapeAnalysisPhase>(); 1444 Run<EscapeAnalysisPhase>();
1445 RunPrintAndVerify("Escape Analysed"); 1445 RunPrintAndVerify("Escape Analysed");
1446 } 1446 }
1447 }
1447 1448
1448 // Select representations. 1449 // Select representations. This has to run w/o the Typer decorator, because
1449 Run<RepresentationSelectionPhase>(); 1450 // we cannot compute meaningful types anyways, and the computed types might
1450 RunPrintAndVerify("Representations selected", true); 1451 // even conflict with the representation/truncation logic.
1451 } 1452 Run<RepresentationSelectionPhase>();
1453 RunPrintAndVerify("Representations selected", true);
1452 1454
1453 #ifdef DEBUG 1455 #ifdef DEBUG
1454 // From now on it is invalid to look at types on the nodes, because: 1456 // From now on it is invalid to look at types on the nodes, because:
1455 // 1457 //
1456 // (a) The remaining passes (might) run concurrent to the main thread and 1458 // (a) The remaining passes (might) run concurrent to the main thread and
1457 // therefore must not access the Heap or the Isolate in an uncontrolled 1459 // therefore must not access the Heap or the Isolate in an uncontrolled
1458 // way (as done by the type system), and 1460 // way (as done by the type system), and
1459 // (b) the types on the nodes might not make sense after representation 1461 // (b) the types on the nodes might not make sense after representation
1460 // selection due to the way we handle truncations; if we'd want to look 1462 // selection due to the way we handle truncations; if we'd want to look
1461 // at types afterwards we'd essentially need to re-type (large portions 1463 // at types afterwards we'd essentially need to re-type (large portions
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
1829 data->DeleteRegisterAllocationZone(); 1831 data->DeleteRegisterAllocationZone();
1830 } 1832 }
1831 1833
1832 CompilationInfo* PipelineImpl::info() const { return data_->info(); } 1834 CompilationInfo* PipelineImpl::info() const { return data_->info(); }
1833 1835
1834 Isolate* PipelineImpl::isolate() const { return info()->isolate(); } 1836 Isolate* PipelineImpl::isolate() const { return info()->isolate(); }
1835 1837
1836 } // namespace compiler 1838 } // namespace compiler
1837 } // namespace internal 1839 } // namespace internal
1838 } // namespace v8 1840 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698