Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2103323003: [turbofan] Don't eagerly introduce machine operators in JSTypedLowering. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@TurboFan_Typing
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't eagerly introduce machine operators in JSTypedLowering. This functionality is duplicated with the same functionality in SimplifiedLowering, which is kinda premature and doesn't seem to be useful. R=jarin@chromium.org Committed: https://crrev.com/e0c87cfce6f01fdb83bf6008f3912218c127524a Cr-Commit-Position: refs/heads/master@{#37386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +1 line, -8 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +9 lines, -22 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Benedikt Meurer
4 years, 5 months ago (2016-06-29 08:51:32 UTC) #1
Jarin
lgtm
4 years, 5 months ago (2016-06-29 08:53:00 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103323003/1
4 years, 5 months ago (2016-06-29 08:55:34 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/4121) v8_linux_nodcheck_rel_ng_triggered on ...
4 years, 5 months ago (2016-06-29 09:24:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103323003/1
4 years, 5 months ago (2016-06-29 10:46:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 11:13:26 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 11:13:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e0c87cfce6f01fdb83bf6008f3912218c127524a
Cr-Commit-Position: refs/heads/master@{#37386}

Powered by Google App Engine
This is Rietveld 408576698