Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: test/cctest/compiler/test-js-typed-lowering.cc

Issue 2103323003: [turbofan] Don't eagerly introduce machine operators in JSTypedLowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@TurboFan_Typing
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-js-typed-lowering.cc
diff --git a/test/cctest/compiler/test-js-typed-lowering.cc b/test/cctest/compiler/test-js-typed-lowering.cc
index 0dac0daa3fa4825a01801ff80cb8e29a86c3a791..f3380dd271603f5cff3e3ad761358a86a4d854c8 100644
--- a/test/cctest/compiler/test-js-typed-lowering.cc
+++ b/test/cctest/compiler/test-js-typed-lowering.cc
@@ -1192,23 +1192,18 @@ TEST(Int32Comparisons) {
struct Entry {
const Operator* js_op;
- const Operator* uint_op;
- const Operator* int_op;
const Operator* num_op;
bool commute;
};
- Entry ops[] = {
- {R.javascript.LessThan(R.compare_hints), R.machine.Uint32LessThan(),
- R.machine.Int32LessThan(), R.simplified.NumberLessThan(), false},
- {R.javascript.LessThanOrEqual(R.compare_hints),
- R.machine.Uint32LessThanOrEqual(), R.machine.Int32LessThanOrEqual(),
- R.simplified.NumberLessThanOrEqual(), false},
- {R.javascript.GreaterThan(R.compare_hints), R.machine.Uint32LessThan(),
- R.machine.Int32LessThan(), R.simplified.NumberLessThan(), true},
- {R.javascript.GreaterThanOrEqual(R.compare_hints),
- R.machine.Uint32LessThanOrEqual(), R.machine.Int32LessThanOrEqual(),
- R.simplified.NumberLessThanOrEqual(), true}};
+ Entry ops[] = {{R.javascript.LessThan(R.compare_hints),
+ R.simplified.NumberLessThan(), false},
+ {R.javascript.LessThanOrEqual(R.compare_hints),
+ R.simplified.NumberLessThanOrEqual(), false},
+ {R.javascript.GreaterThan(R.compare_hints),
+ R.simplified.NumberLessThan(), true},
+ {R.javascript.GreaterThanOrEqual(R.compare_hints),
+ R.simplified.NumberLessThanOrEqual(), true}};
for (size_t o = 0; o < arraysize(ops); o++) {
for (size_t i = 0; i < arraysize(kNumberTypes); i++) {
@@ -1222,15 +1217,7 @@ TEST(Int32Comparisons) {
Node* cmp = R.Binop(ops[o].js_op, p0, p1);
Node* r = R.reduce(cmp);
- const Operator* expected;
- if (t0->Is(Type::Unsigned32()) && t1->Is(Type::Unsigned32())) {
- expected = ops[o].uint_op;
- } else if (t0->Is(Type::Signed32()) && t1->Is(Type::Signed32())) {
- expected = ops[o].int_op;
- } else {
- expected = ops[o].num_op;
- }
- R.CheckBinop(expected, r);
+ R.CheckBinop(ops[o].num_op, r);
if (ops[o].commute) {
CHECK_EQ(p1, r->InputAt(0));
CHECK_EQ(p0, r->InputAt(1));
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698