Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2103043005: media/cast/sender: Rename deadline_utilization to encoder_utilization. (Closed)

Created:
4 years, 5 months ago by miu
Modified:
4 years, 5 months ago
Reviewers:
xjz
CC:
chromium-reviews, imcheng+watch_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, xjz+watch_chromium.org, isheriff+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media/cast/sender: Rename deadline_utilization to encoder_utilization. For HW encoders, we discovered deadline_utilization is not an appropriate benchmark metric; and we plan to test a few alternatives. Before landing those code changes, this change renames the variables and cleans up comments to reflect the new more-abstract meaning. R=xjz@chromium.org NOTRY=true Committed: https://crrev.com/433c11bb5f0d6ed795d9ee4c3b898bb618dec66e Cr-Commit-Position: refs/heads/master@{#403310}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -74 lines) Patch
M media/cast/sender/audio_encoder.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cast/sender/audio_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/external_video_encoder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/cast/sender/fake_software_video_encoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/sender/frame_sender.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/performance_metrics_overlay.h View 2 chunks +8 lines, -8 lines 0 comments Download
M media/cast/sender/performance_metrics_overlay.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M media/cast/sender/sender_encoded_frame.h View 1 chunk +7 lines, -9 lines 0 comments Download
M media/cast/sender/sender_encoded_frame.cc View 1 chunk +1 line, -3 lines 0 comments Download
M media/cast/sender/video_encoder_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/sender/video_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/video_sender.cc View 3 chunks +11 lines, -13 lines 0 comments Download
M media/cast/sender/vp8_encoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/vp8_encoder.cc View 6 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
miu
xjz: PTAL.
4 years, 5 months ago (2016-06-29 21:39:24 UTC) #1
xjz
lgtm
4 years, 5 months ago (2016-06-29 23:15:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103043005/1
4 years, 5 months ago (2016-06-30 19:03:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/255750)
4 years, 5 months ago (2016-06-30 20:13:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103043005/1
4 years, 5 months ago (2016-06-30 20:41:01 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/248796)
4 years, 5 months ago (2016-06-30 22:01:23 UTC) #10
miu
Note: Committing with NOTRY=true because some random churn is still clearing its way out (layout_tests ...
4 years, 5 months ago (2016-06-30 22:04:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103043005/1
4 years, 5 months ago (2016-06-30 22:05:28 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 22:11:29 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 22:11:43 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 22:12:54 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/433c11bb5f0d6ed795d9ee4c3b898bb618dec66e
Cr-Commit-Position: refs/heads/master@{#403310}

Powered by Google App Engine
This is Rietveld 408576698