Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: media/cast/sender/sender_encoded_frame.h

Issue 2103043005: media/cast/sender: Rename deadline_utilization to encoder_utilization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/sender/performance_metrics_overlay.cc ('k') | media/cast/sender/sender_encoded_frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/sender/sender_encoded_frame.h
diff --git a/media/cast/sender/sender_encoded_frame.h b/media/cast/sender/sender_encoded_frame.h
index fa7787d64d0344134d634d73c486e55c976f9e4d..cd0357aac0f7ffb7d0b60be0def9ab4a6292cae0 100644
--- a/media/cast/sender/sender_encoded_frame.h
+++ b/media/cast/sender/sender_encoded_frame.h
@@ -17,18 +17,16 @@ struct SenderEncodedFrame : public EncodedFrame {
SenderEncodedFrame();
~SenderEncodedFrame() final;
- // The amount of real-world time it took to encode the frame, divided by the
- // maximum amount of time allowed. Example: For the software VP8 encoder,
- // this would be the elapsed encode time (according to the base::TimeTicks
- // clock) divided by the VideoFrame's duration.
+ // The amount the encoder was utilized for this frame. Example: For the
+ // software VP8 encoder, this would be the elapsed encode time (according to
+ // the base::TimeTicks clock) divided by the VideoFrame's duration.
//
// Meaningful values are non-negative, with 0.0 [impossibly] representing 0%
// utilization, 1.0 representing 100% utilization, and values greater than 1.0
- // indicating the encode time took longer than the media duration of the
- // frame. Negative values indicate the field was not computed.
- //
- // TODO(miu): Rename to encoder_cpu_utilization.
- double deadline_utilization;
+ // indicating the encoder utilized more resources than a maximum sustainable
+ // rate, based on the data volume of the input. Negative values indicate the
+ // field was not computed.
+ double encoder_utilization;
// The amount of "lossiness" needed to encode the frame within the targeted
// bandwidth. More-complex frame content and/or lower target encode bitrates
« no previous file with comments | « media/cast/sender/performance_metrics_overlay.cc ('k') | media/cast/sender/sender_encoded_frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698