Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: media/cast/sender/performance_metrics_overlay.h

Issue 2103043005: media/cast/sender: Rename deadline_utilization to encoder_utilization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/sender/h264_vt_encoder.cc ('k') | media/cast/sender/performance_metrics_overlay.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/sender/performance_metrics_overlay.h
diff --git a/media/cast/sender/performance_metrics_overlay.h b/media/cast/sender/performance_metrics_overlay.h
index 86f0545d2728a91432895547c84d749c9fbee31c..e9a66524b8bafc066e48b10fcf987feaec9ac7d4 100644
--- a/media/cast/sender/performance_metrics_overlay.h
+++ b/media/cast/sender/performance_metrics_overlay.h
@@ -29,13 +29,13 @@
// | @@@@@@@@@@@@@@@@ 16.7 1280x720 0:15.12 |
// +---------------------------------------------------------------------+
//
-// Line 1: Reads as, "1 frame ago, the encoder deadline utilization for the
-// frame was 45% and the lossy utilization was 75%." Encoder deadline
-// utilization is in terms the amount of real-world time it took to encode the
-// frame, divided by the maximum amount of time allowed. Lossy utilization is
-// the amount of "complexity" in the frame's content versus the target encoded
-// byte size, where a value over 100% means the frame's content is too complex
-// to encode within the target number of bytes.
+// Line 1: Reads as, "1 frame ago, the encoder utilization for the frame was 45%
+// and the lossy utilization was 75%." For CPU-bound encoders, encoder
+// utilization is usually measured as the amount of real-world time it took to
+// encode the frame, divided by the maximum amount of time allowed. Lossy
+// utilization is the amount of "complexity" in the frame's content versus the
+// target encoded byte size, where a value over 100% means the frame's content
+// is too complex to encode within the target number of bytes.
//
// Line 2: Reads as, "Capture of this frame took 22 ms. The current target
// playout delay is 400 ms and low-latency adjustment mode is not active. The
@@ -64,7 +64,7 @@ void MaybeRenderPerformanceMetricsOverlay(base::TimeDelta target_playout_delay,
bool in_low_latency_mode,
int target_bitrate,
int frames_ago,
- double deadline_utilization,
+ double encoder_utilization,
double lossy_utilization,
VideoFrame* frame);
« no previous file with comments | « media/cast/sender/h264_vt_encoder.cc ('k') | media/cast/sender/performance_metrics_overlay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698