Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2102913002: Remove style spans to follow the styles of the block element (Closed)

Created:
1 year, 4 months ago by joone
Modified:
1 year, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove style spans to follow the styles of the block element This CL removes style spans to follow the styles of the block element(li, pre, td, and h1~6) when the text of the pasted or merged element becomes a part of the block element. BUG=226941 TEST=third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block-element.html Committed: https://crrev.com/5220699381aae450f22d1ea3805141deb139f8f3 Cr-Commit-Position: refs/heads/master@{#402659}

Patch Set 1 #

Total comments: 10

Patch Set 2 : Use of assert_selection() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -41 lines) Patch
A third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html View 1 1 chunk +36 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-list-item.html View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/deleting/merge-paragraph-from-p-with-style-3-expected.txt View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 3 chunks +30 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
joone
Hi yosin@, This CL deals with the similar cases to this fix: https://codereview.chromium.org/2072093002/
1 year, 4 months ago (2016-06-28 00:44:35 UTC) #1
joone
Could you review this CL?
1 year, 4 months ago (2016-06-28 00:45:59 UTC) #3
yosin_UTC9
https://codereview.chromium.org/2102913002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html File third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html (right): https://codereview.chromium.org/2102913002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html#newcode33 third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html:33: range.setStart(editor.childNodes[2], 0); Better to use "id" attribute to be ...
1 year, 4 months ago (2016-06-28 01:27:50 UTC) #4
joone
Thank you for the review. :-) The test case became simple. o/ https://codereview.chromium.org/2102913002/diff/1/third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html File third_party/WebKit/LayoutTests/editing/deleting/backspace-merge-into-block.html ...
1 year, 4 months ago (2016-06-28 08:41:43 UTC) #6
yosin_UTC9
lgtm
1 year, 4 months ago (2016-06-29 00:50:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102913002/20001
1 year, 4 months ago (2016-06-29 00:51:10 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
1 year, 4 months ago (2016-06-29 02:15:18 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5220699381aae450f22d1ea3805141deb139f8f3 Cr-Commit-Position: refs/heads/master@{#402659}
1 year, 4 months ago (2016-06-29 02:17:42 UTC) #13
shans
1 year, 4 months ago (2016-06-29 03:05:42 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2109973002/ by shans@chromium.org.

The reason for reverting is: Assignment within conditional on line 836 of
ReplaceSelectionCommand.cpp is breaking Win8 build:

https://build.chromium.org/p/chromium.win/builders/Win8%20GYP%20%28dbg%29/bui....

Powered by Google App Engine
This is Rietveld efc10ee0f