Chromium Code Reviews Chromium Code Reviews
Issue 2102913002:
Remove style spans to follow the styles of the block element (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| (Empty) | |
| 1 <!doctype HTML> | |
| 2 <script src="../../resources/testharness.js"></script> | |
| 3 <script src="../../resources/testharnessreport.js"></script> | |
| 4 <style> | |
| 5 p { | |
| 6 font-size: 20px; | |
| 7 line-height: 22px; | |
| 8 color: red; | |
| 9 } | |
| 10 </style> | |
| 11 <div contenteditable="true" id="editable_h1"> | |
| 12 <h1>Heading 1:</h1> | |
| 13 <p>paragraph was merged.</p> | |
| 14 </div> | |
| 15 <div contenteditable="true" id="editable_pre"> | |
| 16 <pre>Preformatted text:</pre> | |
| 17 <p>paragraph was merged.</p> | |
| 18 </div> | |
| 19 <div contenteditable="true" id="editable_li"> | |
| 20 <ul> | |
| 21 <li>List Item:</li> | |
| 22 </ul> | |
| 23 <p>paragraph was merged.</p> | |
| 24 </div> | |
| 25 <div contenteditable="true" id="editable_table"> | |
| 26 <table><tbody><tr><td>Table:</td></tr></tbody></table> | |
| 27 <p>paragraph was merged.</p> | |
| 28 <script> | |
| 29 test(function() { | |
| 30 var editor = document.getElementById('editable_h1'); | |
| 31 var range = document.createRange(); | |
| 32 var selection = window.getSelection(); | |
| 33 range.setStart(editor.childNodes[2], 0); | |
|
yosin_UTC9
2016/06/28 01:27:50
Better to use "id" attribute to be more specific.
| |
| 34 range.collapse(true); | |
| 35 selection.removeAllRanges(); | |
| 36 selection.addRange(range); | |
|
yosin_UTC9
2016/06/28 01:27:50
|selection.collapse(editor.childNodes[2], 0)| is s
| |
| 37 editor.focus(); | |
| 38 document.execCommand('delete'); | |
| 39 | |
| 40 var html = document.getElementsByTagName('h1')[0].outerHTML; | |
| 41 assert_equals(html, '<h1>Heading 1:paragraph was merged.</h1>'); | |
|
yosin_UTC9
2016/06/28 01:27:50
Can we use |assert_selection()|?
See http://crrev.
joone
2016/06/28 08:41:43
Done.
| |
| 42 }, 'make a paragraph into a heading by backspace'); | |
| 43 | |
| 44 test(function() { | |
| 45 var editor = document.getElementById('editable_pre'); | |
| 46 var range = document.createRange(); | |
| 47 var selection = window.getSelection(); | |
| 48 range.setStart(editor.childNodes[2], 0); | |
| 49 range.collapse(true); | |
| 50 selection.removeAllRanges(); | |
| 51 selection.addRange(range); | |
| 52 editor.focus(); | |
| 53 document.execCommand('delete'); | |
| 54 | |
| 55 var html = document.getElementsByTagName('pre')[0].outerHTML; | |
| 56 assert_equals(html, '<pre>Preformatted text:paragraph was merged.</pre>'); | |
| 57 }, 'make a paragraph into a pre by backspace'); | |
| 58 | |
| 59 test(function() { | |
| 60 var editor = document.getElementById('editable_li'); | |
| 61 var range = document.createRange(); | |
| 62 var selection = window.getSelection(); | |
| 63 range.setStart(editor.childNodes[2], 0); | |
| 64 range.collapse(true); | |
| 65 selection.removeAllRanges(); | |
| 66 selection.addRange(range); | |
| 67 editor.focus(); | |
| 68 document.execCommand('delete'); | |
| 69 | |
| 70 var html = document.getElementsByTagName('li')[0].outerHTML; | |
| 71 assert_equals(html, '<li>List Item:paragraph was merged.</li>'); | |
| 72 }, 'make a paragraph into a list by backspace'); | |
| 73 | |
| 74 test(function() { | |
| 75 var editor = document.getElementById('editable_table'); | |
| 76 var range = document.createRange(); | |
| 77 var selection = window.getSelection(); | |
| 78 range.setStart(editor.childNodes[2], 0); | |
| 79 range.collapse(true); | |
| 80 selection.removeAllRanges(); | |
| 81 selection.addRange(range); | |
| 82 editor.focus(); | |
| 83 document.execCommand('delete'); | |
| 84 | |
| 85 var html = document.getElementsByTagName('table')[0].outerHTML; | |
| 86 assert_equals(html, '<table><tbody><tr><td>Table:paragraph was merged.</td></t r></tbody></table>'); | |
| 87 }, 'make a paragraph into a table by backspace'); | |
| 88 </script> | |
| OLD | NEW |
