Add extra logging when QuicFramer's AppendStopWaiting fails to serialize.

net/quic/quic_framer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_framer.h"
 
 #include <cstdint>
 #include <memory>
 #include <vector>
 
@@ skipping 2479 matching lines @@
   if (quic_version_ <= QUIC_VERSION_33) {
     if (!writer->WriteUInt8(frame.entropy_hash)) {
       QUIC_BUG << " hash failed";
       return false;
     }
   }
 
   if (least_unacked_delta >> length_shift > 0) {
     QUIC_BUG << "packet_number_length "
              << header.public_header.packet_number_length
-             << " is too small for least_unacked_delta: "
-             << least_unacked_delta;
+             << " is too small for least_unacked_delta: " << least_unacked_delta
+             << " packet_number:" << header.packet_number
+             << "least_unacked:" << frame.least_unacked

[ramant (doing other things), 2016/06/27 22:23:54]

overly nit:  "least_unacked:" -> << " least_unacked:"

[Ryan Hamilton, 2016/06/27 22:35:09]

Done. In Final. Thanks!

+             << " version:" << quic_version_;
     return false;
   }
   if (!AppendPacketSequenceNumber(header.public_header.packet_number_length,
                                   least_unacked_delta, writer)) {
     QUIC_BUG << " seq failed: " << header.public_header.packet_number_length;
     return false;
   }
 
   return true;
 }
@@ skipping 77 matching lines @@
 
 bool QuicFramer::RaiseError(QuicErrorCode error) {
   DVLOG(1) << "Error: " << QuicUtils::ErrorToString(error)
            << " detail: " << detailed_error_;
   set_error(error);
   visitor_->OnError(this);
   return false;
 }
 
 }  // namespace net