Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 210243002: DevTools: [Frameworks] Bugfix: do StepOut in framework code after StepIn limit is up. (Closed)

Created:
6 years, 9 months ago by aandrey
Modified:
6 years, 9 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, kojih, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, kouhei+bindings_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Visibility:
Public.

Description

DevTools: [Frameworks] Bugfix: do StepOut in framework code after StepIn limit is up. Bump up the limit from 10 StepIns to 20. Add a test on framework code. BUG=267592 R=pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -9 lines) Patch
A LayoutTests/inspector/sources/debugger/resources/framework.js View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/skip-stack-frames-steps.html View 1 chunk +97 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/skip-stack-frames-steps-expected.txt View 1 chunk +34 lines, -0 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
aandrey
6 years, 9 months ago (2014-03-24 17:10:24 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-24 17:16:59 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-24 17:42:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/210243002/1
6 years, 9 months ago (2014-03-24 17:42:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 17:45:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-24 17:45:19 UTC) #6
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-24 17:47:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/210243002/1
6 years, 9 months ago (2014-03-24 17:47:39 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-24 18:11:38 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-24 18:11:39 UTC) #10
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 9 months ago (2014-03-25 07:34:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/210243002/1
6 years, 9 months ago (2014-03-25 07:34:39 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 08:37:28 UTC) #13
Message was sent while issue was closed. 
Change committed as 169921

Powered by Google App Engine
This is Rietveld 408576698