Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 210243002: DevTools: [Frameworks] Bugfix: do StepOut in framework code after StepIn limit is up. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/ScriptDebugServer.cpp
diff --git a/Source/bindings/v8/ScriptDebugServer.cpp b/Source/bindings/v8/ScriptDebugServer.cpp
index 862fc22eae353aba326392c5a44baafee5372f52..540c948e5d1e72e91b0c23f250651c71fc36aa6a 100644
--- a/Source/bindings/v8/ScriptDebugServer.cpp
+++ b/Source/bindings/v8/ScriptDebugServer.cpp
@@ -414,17 +414,13 @@ void ScriptDebugServer::v8DebugEventCallback(const v8::Debug::EventDetails& even
bool ScriptDebugServer::executeSkipPauseRequest(ScriptDebugListener::SkipPauseRequest request, v8::Handle<v8::Object> executionState)
{
- switch (request) {
- case ScriptDebugListener::NoSkip:
+ if (request == ScriptDebugListener::NoSkip)
return false;
- case ScriptDebugListener::Continue:
+ if (request == ScriptDebugListener::Continue)
return true;
- case ScriptDebugListener::StepInto:
- case ScriptDebugListener::StepOut:
- break;
- }
+ ASSERT(request == ScriptDebugListener::StepInto || request == ScriptDebugListener::StepOut);
v8::Handle<v8::Value> argv[] = { executionState };
- callDebuggerMethod(stepIntoV8MethodName, 1, argv);
+ callDebuggerMethod(request == ScriptDebugListener::StepInto ? stepIntoV8MethodName : stepOutV8MethodName, 1, argv);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698