Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 210243002: DevTools: [Frameworks] Bugfix: do StepOut in framework code after StepIn limit is up. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 } 407 }
408 408
409 void ScriptDebugServer::v8DebugEventCallback(const v8::Debug::EventDetails& even tDetails) 409 void ScriptDebugServer::v8DebugEventCallback(const v8::Debug::EventDetails& even tDetails)
410 { 410 {
411 ScriptDebugServer* thisPtr = toScriptDebugServer(eventDetails.GetCallbackDat a()); 411 ScriptDebugServer* thisPtr = toScriptDebugServer(eventDetails.GetCallbackDat a());
412 thisPtr->handleV8DebugEvent(eventDetails); 412 thisPtr->handleV8DebugEvent(eventDetails);
413 } 413 }
414 414
415 bool ScriptDebugServer::executeSkipPauseRequest(ScriptDebugListener::SkipPauseRe quest request, v8::Handle<v8::Object> executionState) 415 bool ScriptDebugServer::executeSkipPauseRequest(ScriptDebugListener::SkipPauseRe quest request, v8::Handle<v8::Object> executionState)
416 { 416 {
417 switch (request) { 417 if (request == ScriptDebugListener::NoSkip)
418 case ScriptDebugListener::NoSkip:
419 return false; 418 return false;
420 case ScriptDebugListener::Continue: 419 if (request == ScriptDebugListener::Continue)
421 return true; 420 return true;
422 case ScriptDebugListener::StepInto: 421 ASSERT(request == ScriptDebugListener::StepInto || request == ScriptDebugLis tener::StepOut);
423 case ScriptDebugListener::StepOut:
424 break;
425 }
426 v8::Handle<v8::Value> argv[] = { executionState }; 422 v8::Handle<v8::Value> argv[] = { executionState };
427 callDebuggerMethod(stepIntoV8MethodName, 1, argv); 423 callDebuggerMethod(request == ScriptDebugListener::StepInto ? stepIntoV8Meth odName : stepOutV8MethodName, 1, argv);
428 return true; 424 return true;
429 } 425 }
430 426
431 void ScriptDebugServer::handleV8DebugEvent(const v8::Debug::EventDetails& eventD etails) 427 void ScriptDebugServer::handleV8DebugEvent(const v8::Debug::EventDetails& eventD etails)
432 { 428 {
433 v8::DebugEvent event = eventDetails.GetEvent(); 429 v8::DebugEvent event = eventDetails.GetEvent();
434 430
435 if (event == v8::BreakForCommand) { 431 if (event == v8::BreakForCommand) {
436 ClientDataImpl* data = static_cast<ClientDataImpl*>(eventDetails.GetClie ntData()); 432 ClientDataImpl* data = static_cast<ClientDataImpl*>(eventDetails.GetClie ntData());
437 data->task()->run(); 433 data->task()->run();
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
622 { 618 {
623 return PassOwnPtr<ScriptSourceCode>(); 619 return PassOwnPtr<ScriptSourceCode>();
624 } 620 }
625 621
626 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName) 622 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName)
627 { 623 {
628 return source; 624 return source;
629 } 625 }
630 626
631 } // namespace WebCore 627 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698