Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: net/spdy/spdy_header_block_test.cc

Issue 2102253003: Make SpdyHeaderBlock non-copyable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS fix. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_header_block.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_header_block_test.cc
diff --git a/net/spdy/spdy_header_block_test.cc b/net/spdy/spdy_header_block_test.cc
index b0a533d3dace85241397ce8014a92d4c72913dd3..b4273af5c77290bf00fa474eb87f321f4ee96c68 100644
--- a/net/spdy/spdy_header_block_test.cc
+++ b/net/spdy/spdy_header_block_test.cc
@@ -96,17 +96,15 @@ TEST(SpdyHeaderBlockTest, AddHeaders) {
EXPECT_EQ("", block1.GetHeader("key"));
}
-// This test verifies that SpdyHeaderBlock can be copied.
+// This test verifies that SpdyHeaderBlock can be copied using Clone().
TEST(SpdyHeaderBlockTest, CopyBlocks) {
SpdyHeaderBlock block1;
block1["foo"] = string(300, 'x');
block1["bar"] = "baz";
block1.ReplaceOrAppendHeader("qux", "qux1");
- SpdyHeaderBlock block2;
- block2 = block1;
-
- SpdyHeaderBlock block3(block1);
+ SpdyHeaderBlock block2 = block1.Clone();
+ SpdyHeaderBlock block3(block1.Clone());
EXPECT_EQ(block1, block2);
EXPECT_EQ(block1, block3);
« no previous file with comments | « net/spdy/spdy_header_block.cc ('k') | net/spdy/spdy_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698