Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76
Cr-Commit-Position: refs/heads/master@{#403296}

[ccameron, 2016-06-28 23:53:54]

Description was changed from

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile on Mac will originate in RenderWidgetHostViewMac, and
will need to be consumed in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

BUG=622133
==========

to

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile on Mac will originate in RenderWidgetHostViewMac, and
will need to be consumed in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-06-28 23:54:32]

Description was changed from

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile on Mac will originate in RenderWidgetHostViewMac, and
will need to be consumed in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile on Mac will originate in RenderWidgetHostViewMac, and
will need to be consumed in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-06-28 23:54:32]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2016-06-29 00:05:24]

Patchset #2 (id:20001) has been deleted

[ccameron, 2016-06-29 01:24:10]

This has no effect, but would get the data we want from where it is produced
(RWHVMac) to where it is consumed (cc::Renderer/OutputSurface sub-classes).

[enne (OOO), 2016-06-29 18:35:33]

The plumbing looks fine to me in general.

I'm not totally sure that I understand why the color profile needs to originate
in RWHVMac.  Would this same plumbing be reused on other platforms?

[ccameron, 2016-06-29 18:40:11]

On 2016/06/29 18:35:33, enne wrote:
> The plumbing looks fine to me in general.
> 
> I'm not totally sure that I understand why the color profile needs to
originate
> in RWHVMac.  Would this same plumbing be reused on other platforms?

I believe so -- on other platforms, the endpoints (GLRenderer, etc), remain the
same.

For Aura, we will want this to follow the native window as it moves between
screens. The structure for that is aura::WindowTreeHost, which owns a
ui::Compositor.
https://cs.chromium.org/chromium/src/ui/aura/window_tree_host.h?rcl=0&l=43

[enne (OOO), 2016-06-29 18:48:16]

Ok! lgtm

[ccameron, 2016-06-29 19:03:16]

Description was changed from

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile on Mac will originate in RenderWidgetHostViewMac, and
will need to be consumed in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-06-29 19:03:16]

ccameron@chromium.org changed reviewers:
+ boliu@chromium.org, sky@chromium.org

[ccameron, 2016-06-29 19:03:45]

Description was changed from

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ccameron, 2016-06-29 19:05:22]

ccameron@chromium.org changed reviewers:
+ thakis@chromium.org

[ccameron, 2016-06-29 19:05:23]

[updated the patch description to cover the Aura and Mac paths]

Adding OWNERs:
- sky@ for ash/ and components/mus
- boliu@ for android_webview/
- thakis@ for content/

[boliu, 2016-06-29 20:08:11]

On 2016/06/29 19:05:23, ccameron wrote:
> [updated the patch description to cover the Aura and Mac paths]
> 
> Adding OWNERs:
> - sky@ for ash/ and components/mus
> - boliu@ for android_webview/

rs lgtm

> - thakis@ for content/

[sky, 2016-06-29 21:49:05]

LGTM with following fixed.

https://codereview.chromium.org/2102203003/diff/80001/ash/sysui/stub_context_...
File ash/sysui/stub_context_factory.h (right):

https://codereview.chromium.org/2102203003/diff/80001/ash/sysui/stub_context_...
ash/sysui/stub_context_factory.h:44: void SetDisplayColorProfile(ui::Compositor*
compositor,
Don't inline this (see style guide).

[ccameron, 2016-06-29 23:51:52]

Thanks! updated.

just need content/ OWNER now

https://codereview.chromium.org/2102203003/diff/80001/ash/sysui/stub_context_...
File ash/sysui/stub_context_factory.h (right):

https://codereview.chromium.org/2102203003/diff/80001/ash/sysui/stub_context_...
ash/sysui/stub_context_factory.h:44: void SetDisplayColorProfile(ui::Compositor*
compositor,
On 2016/06/29 21:49:04, sky wrote:
> Don't inline this (see style guide).

Done.

[ccameron, 2016-06-30 01:34:37]

ccameron@chromium.org changed reviewers:
+ yfriedman@chromium.org

[ccameron, 2016-06-30 01:34:38]

Adding yfriedman@ for OWNER stamp of content/renderer/android.

[Yaron, 2016-06-30 13:21:41]

lgtm

[ccameron, 2016-06-30 20:45:39]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-06-30 20:45:39]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org,
enne@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2102203003/#ps120001
(title: "Rebase on top of s/ColorProfile/ColorSpace/")

[commit-bot: I haz the power, 2016-06-30 20:46:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 21:36:02]

Description was changed from

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-06-30 21:36:03]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-06-30 21:36:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 21:38:10]

Description was changed from

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Color: Plumb color profile from ui::Compositor to cc::DirectRenderer

The color profile will originate in content::RenderWidgetHostViewMac
on Mac and aura::WindowTreeHost on Aura, and will need to be consumed
in the cc::GLRenderer in a shader and in the
content::GpuSurfacelessBrowserCompositorOutputSurface. Both of
these originating structures have a ui::Compositor.

This follows the same plumbing paths as device scale factor and surface
size.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76
Cr-Commit-Position: refs/heads/master@{#403296}
==========

[commit-bot: I haz the power, 2016-06-30 21:38:12]

Patchset 6 (id:??) landed as
https://crrev.com/3d74bb9bdfc7ceadf52e08d7a4f4ba987a655a76
Cr-Commit-Position: refs/heads/master@{#403296}