Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c
Cr-Commit-Position: refs/heads/master@{#403572}

[ccameron, 2016-06-30 22:16:18]

Description was changed from

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer.

BUG=622133
==========

to

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2016-06-30 22:17:19]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org, fsamuel@chromium.org, sievers@chromium.org

[ccameron, 2016-06-30 22:17:19]

Adding enne@ for color review

Adding fsamuel for mus/ stamp
Adding sievers for gpu/ipc/etc stamp

[ccameron, 2016-07-01 00:02:03]

Description was changed from

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[enne (OOO), 2016-07-01 17:31:23]

lgtm

https://codereview.chromium.org/2119723002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2119723002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:3134: if (screen &&
renderWidgetHostView_->browser_compositor_) {
Doesn't the browser compositor always exist?

[ccameron, 2016-07-01 18:53:16]

Updated.

Also added an OWNERs to gpu/ipc/client so I can stop spamming the same people
for gpu/ root OWNERs.

https://codereview.chromium.org/2119723002/diff/40001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_mac.mm (right):

https://codereview.chromium.org/2119723002/diff/40001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_mac.mm:3134: if (screen &&
renderWidgetHostView_->browser_compositor_) {
On 2016/07/01 17:31:23, enne wrote:
> Doesn't the browser compositor always exist?

There is a brief moment during shutdown when it is nullptr, but I tested this
and it appears not to be hit here.

[no sievers, 2016-07-01 21:23:57]

lgtm

https://codereview.chromium.org/2119723002/diff/60001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2119723002/diff/60001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:29: const gfx::ColorSpace& color_space) {}
nit: NOTIMPLEMENTED()? maybe

[rjkroege, 2016-07-01 21:30:59]

rjkroege@chromium.org changed reviewers:
+ rjkroege@chromium.org

[rjkroege, 2016-07-01 21:31:00]

mus lgtm

[ccameron, 2016-07-01 21:50:07]

Thanks!

https://codereview.chromium.org/2119723002/diff/60001/ui/gfx/gpu_memory_buffe...
File ui/gfx/gpu_memory_buffer.cc (right):

https://codereview.chromium.org/2119723002/diff/60001/ui/gfx/gpu_memory_buffe...
ui/gfx/gpu_memory_buffer.cc:29: const gfx::ColorSpace& color_space) {}
On 2016/07/01 21:23:57, sievers wrote:
> nit: NOTIMPLEMENTED()? maybe

This is still called on all platforms -- I think it would add complexity to make
the callers elide the call if it will not have an effect.

[ccameron, 2016-07-01 22:13:23]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2016-07-01 22:13:23]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2119723002/#ps60001
(title: "Add OWNERs")

[commit-bot: I haz the power, 2016-07-01 22:13:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-02 00:11:38]

Description was changed from

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-02 00:11:39]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-02 00:11:47]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-02 00:14:20]

Description was changed from

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Color: Add SetColorSpace member to gfx::GpuMemoryBuffer

Add implementation on Mac (where the ICC profile is sent to the
IOSurface).

Add plumbing to call this for the backbuffer. Add plumbing to
get this from the RenderWidgetHostViewMac.

BUG=622133
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c
Cr-Commit-Position: refs/heads/master@{#403572}
==========

[commit-bot: I haz the power, 2016-07-02 00:14:21]

Patchset 4 (id:??) landed as
https://crrev.com/9a14007087ef20839871a5284ee3974ada1b208c
Cr-Commit-Position: refs/heads/master@{#403572}

[hubbe, 2016-07-06 21:30:52]

hubbe@chromium.org changed reviewers:
+ hubbe@chromium.org

[hubbe, 2016-07-06 21:30:53]

https://codereview.chromium.org/2119723002/diff/60001/components/display_comp...
File components/display_compositor/buffer_queue.cc (right):

https://codereview.chromium.org/2119723002/diff/60001/components/display_comp...
components/display_compositor/buffer_queue.cc:113: if (size == size_ &&
color_space == color_space_)
Isn't this the kind of comparison you were worried about becoming a hotspot when
we talked earlier?

[ccameron, 2016-07-06 21:35:06]

On 2016/07/06 21:30:53, hubbe wrote:
>
https://codereview.chromium.org/2119723002/diff/60001/components/display_comp...
> File components/display_compositor/buffer_queue.cc (right):
> 
>
https://codereview.chromium.org/2119723002/diff/60001/components/display_comp...
> components/display_compositor/buffer_queue.cc:113: if (size == size_ &&
> color_space == color_space_)
> Isn't this the kind of comparison you were worried about becoming a hotspot
when
> we talked earlier?

Yes. It's not hurting at the moment, but we need a way to optimize this. I'm
thinking to add a sequence number to ICC profiles to elide the comparison.