Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2106303002: Color: Rename gfx::ColorProfile to gfx::ColorSpace (Closed)

Created:
4 years, 5 months ago by ccameron
Modified:
4 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, hubbe, jam, jbauman+watch_chromium.org, kalyank, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, piman+watch_chromium.org, shuchen+watch_chromium.org, sievers+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Color: Rename gfx::ColorProfile to gfx::ColorSpace This is more accurate terminology. A color space can be represented by ICC profile. There isn't really such a thing as a "color profile". BUG=622133 Committed: https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29 Cr-Commit-Position: refs/heads/master@{#403275}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -231 lines) Patch
M content/browser/renderer_host/render_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
D ui/gfx/color_profile.h View 1 chunk +0 lines, -48 lines 0 comments Download
D ui/gfx/color_profile.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/gfx/color_profile_mac.mm View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/gfx/color_profile_win.cc View 1 chunk +0 lines, -68 lines 0 comments Download
A + ui/gfx/color_space.h View 2 chunks +20 lines, -20 lines 0 comments Download
A ui/gfx/color_space.cc View 1 chunk +44 lines, -0 lines 0 comments Download
A + ui/gfx/color_space_mac.mm View 2 chunks +7 lines, -7 lines 0 comments Download
A ui/gfx/color_space_win.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (7 generated)
ccameron
Adding enne@ for the renaming change. Adding thakis@ for content/ OWNER.
4 years, 5 months ago (2016-06-30 01:17:39 UTC) #2
Nico
last i checked i wasn't a content/owner. do you mean ui/owner?
4 years, 5 months ago (2016-06-30 01:19:44 UTC) #3
ccameron
On 2016/06/30 01:19:44, Nico wrote: > last i checked i wasn't a content/owner. do you ...
4 years, 5 months ago (2016-06-30 01:25:30 UTC) #4
ccameron
->sievers for content/ OWNER
4 years, 5 months ago (2016-06-30 01:46:01 UTC) #7
enne (OOO)
lgtm
4 years, 5 months ago (2016-06-30 17:24:02 UTC) #8
esprehn
lgtm
4 years, 5 months ago (2016-06-30 19:34:02 UTC) #10
ccameron
Thanks!
4 years, 5 months ago (2016-06-30 19:36:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2106303002/1
4 years, 5 months ago (2016-06-30 19:37:12 UTC) #13
no sievers
lgtm
4 years, 5 months ago (2016-06-30 19:59:45 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 20:44:49 UTC) #16
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 20:44:52 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 20:47:43 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ea67932168cc5b1f5685a655c667b4a083f6f29
Cr-Commit-Position: refs/heads/master@{#403275}

Powered by Google App Engine
This is Rietveld 408576698