content/renderer/child_frame_compositing_helper.h - Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/child_frame_compositing_helper.h

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/renderer/child_frame_compositing_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/child_frame_compositing_helper.h

diff --git a/content/renderer/child_frame_compositing_helper.h b/content/renderer/child_frame_compositing_helper.h

index e51ab82870bdb08f358d865d194a760bc11c8531..09548c71f923cacbced6ede7e75fa7a704513159 100644

--- a/content/renderer/child_frame_compositing_helper.h

+++ b/content/renderer/child_frame_compositing_helper.h

@@ -93,22 +93,22 @@ class CONTENT_EXPORT ChildFrameCompositingHelper

cc::Layer* layer);

static void SatisfyCallback(scoped_refptr<ThreadSafeSender> sender,

int host_routing_id,

- cc::SurfaceSequence sequence);

+ const cc::SurfaceSequence& sequence);

static void SatisfyCallbackBrowserPlugin(

scoped_refptr<ThreadSafeSender> sender,

int host_routing_id,

int browser_plugin_instance_id,

- cc::SurfaceSequence sequence);

+ const cc::SurfaceSequence& sequence);

static void RequireCallback(scoped_refptr<ThreadSafeSender> sender,

int host_routing_id,

- cc::SurfaceId id,

- cc::SurfaceSequence sequence);

+ const cc::SurfaceId& id,

+ const cc::SurfaceSequence& sequence);

static void RequireCallbackBrowserPlugin(

scoped_refptr<ThreadSafeSender> sender,

int host_routing_id,

int browser_plugin_instance_id,

- cc::SurfaceId id,

- cc::SurfaceSequence sequence);

+ const cc::SurfaceId& id,

+ const cc::SurfaceSequence& sequence);

void UpdateWebLayer(blink::WebLayer* layer);

int host_routing_id_;