Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2729)

Unified Diff: content/renderer/child_frame_compositing_helper.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/child_frame_compositing_helper.cc
diff --git a/content/renderer/child_frame_compositing_helper.cc b/content/renderer/child_frame_compositing_helper.cc
index cc2ba004c4d0ef80aea5ef37152d78001b094e9e..9b98bc69ec18c0246a18eb17b872a63aa8699204 100644
--- a/content/renderer/child_frame_compositing_helper.cc
+++ b/content/renderer/child_frame_compositing_helper.cc
@@ -149,7 +149,7 @@ void ChildFrameCompositingHelper::ChildFrameGone() {
void ChildFrameCompositingHelper::SatisfyCallback(
scoped_refptr<ThreadSafeSender> sender,
int host_routing_id,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceSequence& sequence) {
// This may be called on either the main or impl thread.
sender->Send(new FrameHostMsg_SatisfySequence(host_routing_id, sequence));
}
@@ -159,7 +159,7 @@ void ChildFrameCompositingHelper::SatisfyCallbackBrowserPlugin(
scoped_refptr<ThreadSafeSender> sender,
int host_routing_id,
int browser_plugin_instance_id,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceSequence& sequence) {
sender->Send(new BrowserPluginHostMsg_SatisfySequence(
host_routing_id, browser_plugin_instance_id, sequence));
}
@@ -168,8 +168,8 @@ void ChildFrameCompositingHelper::SatisfyCallbackBrowserPlugin(
void ChildFrameCompositingHelper::RequireCallback(
scoped_refptr<ThreadSafeSender> sender,
int host_routing_id,
- cc::SurfaceId id,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceId& id,
+ const cc::SurfaceSequence& sequence) {
// This may be called on either the main or impl thread.
sender->Send(new FrameHostMsg_RequireSequence(host_routing_id, id, sequence));
}
@@ -178,8 +178,8 @@ void ChildFrameCompositingHelper::RequireCallbackBrowserPlugin(
scoped_refptr<ThreadSafeSender> sender,
int host_routing_id,
int browser_plugin_instance_id,
- cc::SurfaceId id,
- cc::SurfaceSequence sequence) {
+ const cc::SurfaceId& id,
+ const cc::SurfaceSequence& sequence) {
// This may be called on either the main or impl thread.
sender->Send(new BrowserPluginHostMsg_RequireSequence(
host_routing_id, browser_plugin_instance_id, id, sequence));

Powered by Google App Engine
This is Rietveld 408576698