content/browser/renderer_host/render_widget_host_view_android.cc - Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/offscreen_canvas_surface_impl.cc ('k') | content/renderer/child_frame_compositing_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index a81452238b1206e3e00e7ef5ff8e9797465a67e6..3bd20ad70a479e32bb126795f355c7af63b98c5e 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -96,15 +96,15 @@ namespace content {

namespace {

void SatisfyCallback(cc::SurfaceManager* manager,

- cc::SurfaceSequence sequence) {

+ const cc::SurfaceSequence& sequence) {

std::vector<uint32_t> sequences;

sequences.push_back(sequence.sequence);

manager->DidSatisfySequences(sequence.id_namespace, &sequences);

}

void RequireCallback(cc::SurfaceManager* manager,

- cc::SurfaceId id,

- cc::SurfaceSequence sequence) {

+ const cc::SurfaceId& id,

+ const cc::SurfaceSequence& sequence) {

cc::Surface* surface = manager->GetSurfaceForId(id);

if (!surface) {

LOG(ERROR) << "Attempting to require callback on nonexistent surface";