content/browser/renderer_host/offscreen_canvas_surface_impl.cc - Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2102123002: Make Satisfy/Require callbacks pass Surface id and sequence by reference (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/offscreen_canvas_surface_impl.h ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

index e6b85f59a9fbdc0e0126b1cae964f6f058965466..8e56b01416afb1a9c77b66fa8fb89a0ebe9253b8 100644

--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

@@ -29,9 +29,9 @@ OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {

// Inform both members that SurfaceManager's no longer alive to

// avoid their destruction errors.

if (surface_factory_)

- surface_factory_->didDestroySurfaceManager();

+ surface_factory_->DidDestroySurfaceManager();

if (id_allocator_)

- id_allocator_->didDestroySurfaceManager();

+ id_allocator_->DidDestroySurfaceManager();

}

surface_factory_->Destroy(surface_id_);

}

@@ -77,7 +77,7 @@ void OffscreenCanvasSurfaceImpl::Satisfy(const cc::SurfaceSequence& sequence) {

void OffscreenCanvasSurfaceImpl::ReturnResources(

const cc::ReturnedResourceArray& resources) {}

-void OffscreenCanvasSurfaceImpl::WillDrawSurface(cc::SurfaceId id,

+void OffscreenCanvasSurfaceImpl::WillDrawSurface(const cc::SurfaceId& id,

const gfx::Rect& damage_rect) {

}