Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 2102063002: MIPS: [turbofan] Fix addition for deoptimization. (Closed)

Created:
4 years, 5 months ago by miran.karic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Fix addition for deoptimization. In turbofan, after an addition operation where the same register is the output and both inputs, if deoptimization is performed the input is overwritten with the output value and the final result is not correct. This is fixed by restoring the original value of the input before deoptimization. BUG= TEST=mjsunit/regress/regress-int32-truncation Committed: https://crrev.com/99385e8e4bcef1f333ede61c936528bfc0c8ecfa Cr-Commit-Position: refs/heads/master@{#37524}

Patch Set 1 #

Patch Set 2 : Add fix for mips32 #

Patch Set 3 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 1 2 1 chunk +12 lines, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
miran.karic
PTAL
4 years, 5 months ago (2016-07-04 13:42:12 UTC) #3
balazs.kilvady
Please fix the message: MIPS: [turbofan] Fix addition for deoptimization. blabla... TEST=mjsunit/regress/regress-int32-truncation
4 years, 5 months ago (2016-07-05 10:12:51 UTC) #4
miran.karic
On 2016/07/05 10:12:51, balazs.kilvady wrote: > Please fix the message: > MIPS: [turbofan] Fix addition ...
4 years, 5 months ago (2016-07-05 10:52:34 UTC) #7
balazs.kilvady
lgtm
4 years, 5 months ago (2016-07-05 10:54:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102063002/40001
4 years, 5 months ago (2016-07-05 10:59:36 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-05 11:23:22 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/99385e8e4bcef1f333ede61c936528bfc0c8ecfa Cr-Commit-Position: refs/heads/master@{#37524}
4 years, 5 months ago (2016-07-05 11:24:23 UTC) #14
miran.karic
4 years, 5 months ago (2016-07-08 13:07:54 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2129083003/ by Miran.Karic@imgtec.com.

The reason for reverting is: This workaround is no longer needed, port of
e60c4053c7f9d6e44b995c77ab3ec561aec83c9c fixes the issue..

Powered by Google App Engine
This is Rietveld 408576698