Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2101943004: content: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, no sievers, dcheng
CC:
chromium-reviews, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, posciak+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, dmazzoni+watch_chromium.org, tracing+reviews_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, cbentzel+watch_chromium.org, mlamouri+watch-geolocation_chromium.org, aboxhall+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, je_julie, darin-cc_chromium.org, devtools-reviews_chromium.org, loading-reviews_chromium.org, kalyank, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, dtseng+watch_chromium.org, qsr+mojo_chromium.org, wjmaclean, yuzo+watch_chromium.org, Randy Smith (Not in Mondays), feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, Michael van Ouwerkerk, piman+watch_chromium.org, jsbell+idb_chromium.org, darin (slow to review), jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, toyoshim+midi_chromium.org, wfh+watch_chromium.org, nektar+watch_chromium.org, Aaron Boodman, pfeldman, cmumford, danakj+watch_chromium.org, James Su, scheduler-bugs_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=sievers, danakj, dcheng BUG=554600 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/10e0d5f672745230042c700577feb7fc66f00f15 Cr-Commit-Position: refs/heads/master@{#406994}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase/update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -122 lines) Patch
M content/browser/accessibility/accessibility_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 7 chunks +9 lines, -8 lines 0 comments Download
M content/browser/android/web_contents_observer_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_area.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_context_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/dom_storage/session_storage_database.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/cross_process_frame_connector.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/frame_tree_node_blame_context_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/network_location_request.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/host_zoom_map_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/indexed_db_database.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/async_revalidation_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/cdm/browser_cdm_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc/webrtc_eventlog_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/text_input_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_per_process_browsertest.cc View 1 2 10 chunks +12 lines, -12 lines 0 comments Download
M content/browser/tracing/background_tracing_config_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/background_tracing_manager_impl.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/tracing/tracing_controller_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tracing/tracing_controller_impl.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/child/indexed_db/indexed_db_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle.cc View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/android/synchronous_compositor_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 4 chunks +12 lines, -8 lines 0 comments Download
M content/renderer/media/media_recorder_handler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/media_stream_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/midi_message_filter.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/stun_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/presentation/presentation_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_android.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/scheduler/resource_dispatch_throttler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/blink_test_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:21:38 UTC) #2
dcheng
lgtm
4 years, 5 months ago (2016-07-01 06:39:28 UTC) #3
vmpstr
rebased/updated. sievers@, can you please take a look?
4 years, 5 months ago (2016-07-18 20:40:08 UTC) #4
no sievers
On 2016/07/18 20:40:08, vmpstr wrote: > rebased/updated. sievers@, can you please take a look? lgtm
4 years, 5 months ago (2016-07-21 22:11:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101943004/40001
4 years, 5 months ago (2016-07-21 22:23:28 UTC) #8
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-21 22:23:31 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-21 23:46:31 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:47:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/10e0d5f672745230042c700577feb7fc66f00f15
Cr-Commit-Position: refs/heads/master@{#406994}

Powered by Google App Engine
This is Rietveld 408576698