content/browser/accessibility/browser_accessibility_manager.cc - Issue 2101943004: content: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager.cc

Issue 2101943004: content: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase/update Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/accessibility/browser_accessibility_manager.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager.cc b/content/browser/accessibility/browser_accessibility_manager.cc

index d2fb4326fb4342f16770d8e616400ca732e03b67..148bc70e2ee75c26f3914eba1d77d537ba1a4134 100644

--- a/content/browser/accessibility/browser_accessibility_manager.cc

+++ b/content/browser/accessibility/browser_accessibility_manager.cc

@@ -691,8 +691,8 @@ bool BrowserAccessibilityManager::FindIndicesInCommonParent(

int* child_index1,

int* child_index2) {

DCHECK(common_parent && child_index1 && child_index2);

- auto ancestor1 = const_cast<BrowserAccessibility*>(&object1);

- auto ancestor2 = const_cast<BrowserAccessibility*>(&object2);

+ auto* ancestor1 = const_cast<BrowserAccessibility*>(&object1);

+ auto* ancestor2 = const_cast<BrowserAccessibility*>(&object2);

do {

*child_index1 = ancestor1->GetIndexInParent();

ancestor1 = ancestor1->GetParent();