Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1717)

Unified Diff: content/browser/tracing/background_tracing_manager_impl.cc

Issue 2101943004: content: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase/update Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tracing/background_tracing_manager_impl.cc
diff --git a/content/browser/tracing/background_tracing_manager_impl.cc b/content/browser/tracing/background_tracing_manager_impl.cc
index 33f9531a75a20182b6c1d8f7f45bf73b1235f69c..0fa36ef58a13dbc5395bebc2fabed971c7c04b4e 100644
--- a/content/browser/tracing/background_tracing_manager_impl.cc
+++ b/content/browser/tracing/background_tracing_manager_impl.cc
@@ -52,7 +52,7 @@ void RecordBackgroundTracingMetric(BackgroundTracingMetrics metric) {
// Tracing enabled callback for BENCHMARK_MEMORY_LIGHT category preset.
void BenchmarkMemoryLight_TracingEnabledCallback() {
- auto dump_manager = base::trace_event::MemoryDumpManager::GetInstance();
+ auto* dump_manager = base::trace_event::MemoryDumpManager::GetInstance();
dump_manager->RequestGlobalDump(
base::trace_event::MemoryDumpType::EXPLICITLY_TRIGGERED,
base::trace_event::MemoryDumpLevelOfDetail::BACKGROUND);
@@ -179,7 +179,7 @@ bool BackgroundTracingManagerImpl::SetActiveScenario(
if (config_) {
DCHECK(!config_.get()->rules().empty());
- for (auto& rule : config_.get()->rules())
+ for (auto* rule : config_.get()->rules())
static_cast<BackgroundTracingRule*>(rule)->Install();
if (!config_->enable_blink_features().empty()) {
@@ -243,7 +243,7 @@ BackgroundTracingManagerImpl::GetRuleAbleToTriggerTracing(
}
std::string trigger_name = GetTriggerNameFromHandle(handle);
- for (const auto& rule : config_.get()->rules()) {
+ for (auto* rule : config_.get()->rules()) {
if (static_cast<BackgroundTracingRule*>(rule)
->ShouldTriggerNamedEvent(trigger_name))
return static_cast<BackgroundTracingRule*>(rule);
@@ -262,7 +262,7 @@ void BackgroundTracingManagerImpl::OnHistogramTrigger(
return;
}
- for (const auto& rule : config_->rules()) {
+ for (auto* rule : config_->rules()) {
if (rule->ShouldTriggerNamedEvent(histogram_name))
OnRuleTriggered(rule, StartedFinalizingCallback());
}
« no previous file with comments | « content/browser/tracing/background_tracing_config_impl.cc ('k') | content/browser/tracing/tracing_controller_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698