Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2101653002: Revert of Refactoring of CPU NormalMap handling out into its own class (Closed)

Created:
4 years, 5 months ago by dvonbeck
Modified:
4 years, 5 months ago
Reviewers:
egdaniel, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@dvonbeck-normals-gpu-cl
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Refactoring of CPU NormalMap handling out into its own class (patchset #13 id:240001 of https://codereview.chromium.org/2050773002/ ) Reason for revert: GMs are crashing on Windows Test trybots Original issue's description: > SkLightingShader normal vector CPU computation refactor. > > The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources. > > This CL's base was the CL for GPU handling: https://codereview.chromium.org/2043393002/ > > What this CL includes: > > - A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2050773002 > > Committed: https://skia.googlesource.com/skia/+/790a70118327a129cb6b48fabe80f4e184c1e67c TBR=egdaniel@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/2c80711f90a5dafe3b726bc6562b1e769702c34b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -424 lines) Patch
M gyp/core.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M include/core/SkFlattenable.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkLightingShader.h View 2 chunks +51 lines, -6 lines 0 comments Download
M src/core/SkLightingShader.cpp View 16 chunks +78 lines, -43 lines 0 comments Download
A src/core/SkLightingShader_NormalSource.cpp View 1 chunk +290 lines, -0 lines 0 comments Download
D src/core/SkNormalSource.h View 1 chunk +0 lines, -76 lines 0 comments Download
D src/core/SkNormalSource.cpp View 1 chunk +0 lines, -294 lines 0 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dvonbeck
Created Revert of Refactoring of CPU NormalMap handling out into its own class
4 years, 5 months ago (2016-06-27 16:30:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101653002/1
4 years, 5 months ago (2016-06-27 16:30:14 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 16:30:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2c80711f90a5dafe3b726bc6562b1e769702c34b

Powered by Google App Engine
This is Rietveld 408576698