Issue 2101393002: Make visualViewport.scrollTop/Left readonly.

Issue 2101393002: Make visualViewport.scrollTop/Left readonly. (Closed)

Created:
4 years, 5 months ago by ymalik

Modified:
4 years, 5 months ago

Reviewers:
bokan

CC:
chromium-reviews, blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Make visualViewport.scrollTop/Left readonly. BUG=595826 Committed: https://crrev.com/138923ac69f895f225d668b8f677ef147103ac70 Cr-Commit-Position: refs/heads/master@{#402513}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -94 lines)			Patch
M	third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html	View	2 chunks	+1 line, -20 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html	View	2 chunks	+16 lines, -21 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/DOMVisualViewport.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/VisualViewport.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/VisualViewport.cpp	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/VisualViewport.idl	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 10 (5 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101393002/1

4 years, 5 months ago (2016-06-28 17:52:00 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-06-28 19:38:51 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/138923ac69f895f225d668b8f677ef147103ac70
Cr-Commit-Position: refs/heads/master@{#402513}