third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html - Issue 2101393002: Make visualViewport.scrollTop/Left readonly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html

Issue 2101393002: Make visualViewport.scrollTop/Left readonly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/viewport/scroll-resize-events-fired.html ('k') | third_party/WebKit/LayoutTests/fast/dom/viewport/viewport-dimensions-under-browser-zoom.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html

diff --git a/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html b/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html

index d58f3b193e5f165f915af36fbf33cc5fb1d83831..cfb4167b3446e1f9274d814cf5a992399007bad9 100644

--- a/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html

+++ b/third_party/WebKit/LayoutTests/fast/dom/viewport/verify-viewport-dimensions.html

@@ -44,14 +44,12 @@

assert_equals(viewport().scale, 2, "scale");

// Set scrollTop/Left.

- window.visualViewport.scrollTop = 20;

- window.visualViewport.scrollLeft = 0;

+ internals.setVisualViewportOffset(0, 20);

assert_equals(viewport().scrollTop, 20, "set scrollTop");

assert_equals(viewport().scrollLeft, 0, "set scrollLeft");

- window.visualViewport.scrollTop = -20;

+ internals.setVisualViewportOffset(-20, -20);

assert_equals(viewport().scrollTop, 0, "negative scrollTop");

- window.visualViewport.scrollTop = 20.5;

- assert_equals(viewport().scrollTop, 20.5, "floating point scrollTop");

+ assert_equals(viewport().scrollTop, 0, "negative scrollLeft");

t.done();

});