third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp - Issue 2101393002: Make visualViewport.scrollTop/Left readonly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp

Issue 2101393002: Make visualViewport.scrollTop/Left readonly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp b/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp

index 620fe5f4fdaf3cd9e73b11802c160e0ec15c4b87..2eae2a1878b4e91e7ccdab438068bb4be18efcf3 100644

--- a/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMVisualViewport.cpp

@@ -85,26 +85,6 @@ double DOMVisualViewport::scrollTop()

return 0;

}

-void DOMVisualViewport::setScrollLeft(double x)

- LocalFrame* frame = m_window->frame();

- if (!frame || !frame->isMainFrame())

- return;

- if (FrameHost* host = frame->host())

- host->visualViewport().setScrollLeft(x);

-void DOMVisualViewport::setScrollTop(double y)

- LocalFrame* frame = m_window->frame();

- if (!frame || !frame->isMainFrame())

- return;

- if (FrameHost* host = frame->host())

- host->visualViewport().setScrollTop(y);

double DOMVisualViewport::clientWidth()

{

LocalFrame* frame = m_window->frame();