Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2100553002: Add Core methods for wait set. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work790_wait_set_5.4
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add Core methods for wait set. Still left to do (separately): * Add thunks. * Add tests of the actual "public" interface. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/58caf04a2051468cc56883fb8df20c61a7c90b1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -52 lines) Patch
M mojo/edk/system/core.h View 2 chunks +17 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 2 chunks +84 lines, -0 lines 0 comments Download
M mojo/edk/system/core_test_base.h View 3 chunks +9 lines, -0 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 3 chunks +55 lines, -0 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 4 chunks +86 lines, -0 lines 0 comments Download
M mojo/edk/system/dispatcher.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher_unittest.cc View 9 chunks +29 lines, -32 lines 0 comments Download
M mojo/public/c/system/wait_set.h View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 2099863002 Patch 1

Dependent Patchsets:

Issue 2106433002 Patch 1

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-24 23:42:37 UTC) #1
viettrungluu
ping
4 years, 5 months ago (2016-06-27 18:12:28 UTC) #2
vardhan
lgtm
4 years, 5 months ago (2016-06-27 19:24:51 UTC) #3
viettrungluu
4 years, 5 months ago (2016-06-27 19:35:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
58caf04a2051468cc56883fb8df20c61a7c90b1b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698