Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2106433002: Add thunks for wait set operations, together with public tests. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work791_wait_set_6-x-work790_wait_set_5.4
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add thunks for wait set operations, together with public tests. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/030360fa7ac55cf83abfd6ea4420470e160de269

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -4 lines) Patch
M mojo/edk/embedder/entrypoints.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/tests/buffer_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/tests/data_pipe_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/handle_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/tests/message_pipe_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/result_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/c/system/tests/time_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/c/system/tests/wait_set_unittest.cc View 1 chunk +390 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/wait_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/c/system/wait_set.h View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 2 chunks +39 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 2 chunks +15 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.h View 3 chunks +18 lines, -1 line 0 comments Download
M mojo/public/platform/native/system_thunks.c View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 5 months ago (2016-06-27 17:49:22 UTC) #1
vardhan
lgtm, but tests Linux fail
4 years, 5 months ago (2016-06-27 19:31:26 UTC) #2
viettrungluu
On 2016/06/27 19:31:26, vardhan wrote: > lgtm, but tests Linux fail D'oh, thanks for catching ...
4 years, 5 months ago (2016-06-27 19:47:33 UTC) #3
viettrungluu
4 years, 5 months ago (2016-06-27 19:53:16 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
030360fa7ac55cf83abfd6ea4420470e160de269 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698