Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: mojo/edk/system/dispatcher.cc

Issue 2100553002: Add Core methods for wait set. (Closed) Base URL: https://github.com/domokit/mojo.git@work790_wait_set_5.4
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/dispatcher.h ('k') | mojo/edk/system/wait_set_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/dispatcher.cc
diff --git a/mojo/edk/system/dispatcher.cc b/mojo/edk/system/dispatcher.cc
index dc62e0590e3d77d27f705b1cacc575507f743be7..bad499f79cff2f51144ca2a6f6ba26721d2aa228 100644
--- a/mojo/edk/system/dispatcher.cc
+++ b/mojo/edk/system/dispatcher.cc
@@ -279,11 +279,11 @@ MojoResult Dispatcher::MapBuffer(
// everything for |WaitSet...Impl()| to do. (We could just make these methods
// virtual, but we prefer to have a separate "impl" methods for consistency.)
MojoResult Dispatcher::WaitSetAdd(
- UserPointer<const MojoWaitSetAddOptions> options,
RefPtr<Dispatcher>&& dispatcher,
MojoHandleSignals signals,
- uint64_t cookie) {
- return WaitSetAddImpl(options, std::move(dispatcher), signals, cookie);
+ uint64_t cookie,
+ UserPointer<const MojoWaitSetAddOptions> options) {
+ return WaitSetAddImpl(std::move(dispatcher), signals, cookie, options);
}
MojoResult Dispatcher::WaitSetRemove(uint64_t cookie) {
@@ -511,10 +511,10 @@ MojoResult Dispatcher::MapBufferImplNoLock(
// methods are only needed for wait set dispatchers), we don't need to lock
// |mutex_| and check |is_closed_|.
MojoResult Dispatcher::WaitSetAddImpl(
- UserPointer<const MojoWaitSetAddOptions> /*options*/,
RefPtr<Dispatcher>&& /*dispatcher*/,
MojoHandleSignals /*signals*/,
- uint64_t /*cookie*/) {
+ uint64_t /*cookie*/,
+ UserPointer<const MojoWaitSetAddOptions> /*options*/) {
// See note above.
return MOJO_RESULT_INVALID_ARGUMENT;
}
« no previous file with comments | « mojo/edk/system/dispatcher.h ('k') | mojo/edk/system/wait_set_dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698