Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2100013004: M52 fix2 for "Allowing prerendering on cellular also disables throttling." (Closed)

Created:
4 years, 5 months ago by pasko
Modified:
4 years, 5 months ago
Reviewers:
gone
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

M52 fix2 for "Allowing prerendering on cellular also disables throttling." Beta branch is broken with a cherry-pick of: https://codereview.chromium.org/2080173006 Then the chrome_apk was fixed with: https://codereview.chromium.org/2096393002 ... but forgot the tests :( This change makes the newly added _tests_ in the first patch to compile (should PASS as well, but have not checked). BUG=522099 R=dfalcantara@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a3816dee270e4612599a6d6e94b563772e56cc0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionTest.java View 4 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pasko
4 years, 5 months ago (2016-06-27 17:23:44 UTC) #3
gone
lgtm for what seems to be a mostly mechanical change
4 years, 5 months ago (2016-06-27 17:28:16 UTC) #4
pasko
4 years, 5 months ago (2016-06-27 17:37:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3816dee270e4612599a6d6e94b563772e56cc0e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698