Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2096393002: M52 fix for "Allowing prerendering on cellular also disables throttling." (Closed)

Created:
4 years, 5 months ago by pasko
Modified:
4 years, 5 months ago
Reviewers:
clamy
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

M52 fix for "Allowing prerendering on cellular also disables throttling." Beta branch is broken with a cherry-pick of: https://codereview.chromium.org/2080173006 BUG=522099 R=clamy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/7aa7e336e10c1ae0707575ddaa0e32ec3ef1f73c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
pasko
4 years, 5 months ago (2016-06-27 12:02:03 UTC) #3
clamy
rs lgtm
4 years, 5 months ago (2016-06-27 12:05:44 UTC) #4
pasko
The reason for the conflict is this refactoring that changed uses of IBinder to CustomTabsSessionToken ...
4 years, 5 months ago (2016-06-27 12:06:59 UTC) #5
pasko
4 years, 5 months ago (2016-06-27 12:14:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7aa7e336e10c1ae0707575ddaa0e32ec3ef1f73c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698