Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2080173006: customtabs: Allowing prerendering on cellular also disables throttling. (Closed)

Created:
4 years, 6 months ago by Benoit L
Modified:
4 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

customtabs: Allowing prerendering on cellular also disables throttling. Committed: https://crrev.com/76d811969eff8f2097fc366dd646faac65667def Cr-Commit-Position: refs/heads/master@{#401238}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add a test. #

Messages

Total messages: 16 (7 generated)
Benoit L
4 years, 6 months ago (2016-06-20 15:32:13 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080173006/1
4 years, 6 months ago (2016-06-20 15:32:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 16:18:26 UTC) #6
Benoit L
4 years, 6 months ago (2016-06-20 16:31:59 UTC) #8
Yusuf
lgtm with a question https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java (right): https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java#newcode708 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:708: if (throttle && !mClientManager.isPrerenderingAllowed(uid)) return ...
4 years, 6 months ago (2016-06-21 08:31:26 UTC) #9
Benoit L
Thanks! Added a test as well. https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java (right): https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java#newcode708 chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:708: if (throttle && ...
4 years, 6 months ago (2016-06-21 11:31:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2080173006/20001
4 years, 6 months ago (2016-06-22 08:31:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-22 09:23:04 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-22 09:24:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76d811969eff8f2097fc366dd646faac65667def
Cr-Commit-Position: refs/heads/master@{#401238}

Powered by Google App Engine
This is Rietveld 408576698