customtabs: Allowing prerendering on cellular also disables throttling.

customtabs: Allowing prerendering on cellular also disables throttling.

Committed: https://crrev.com/76d811969eff8f2097fc366dd646faac65667def
Cr-Commit-Position: refs/heads/master@{#401238}

[Benoit L, 2016-06-20 15:31:55]

The CQ bit was checked by lizeb@chromium.org to run a CQ dry run

[Benoit L, 2016-06-20 15:32:07]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[commit-bot: I haz the power, 2016-06-20 15:32:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080173006/1

[commit-bot: I haz the power, 2016-06-20 16:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 16:18:26]

Dry run: This issue passed the CQ dry run.

[Benoit L, 2016-06-20 16:31:58]

lizeb@chromium.org changed reviewers:
+ yusufo@chromium.org

[Yusuf, 2016-06-21 08:31:26]

lgtm with a question

https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:708:
if (throttle && !mClientManager.isPrerenderingAllowed(uid)) return false;
Won't this have the side effect of allowing apps that can prerender on cellular
to prerender even if the user has turned off the prerender setting?

[Benoit L, 2016-06-21 11:31:58]

Thanks!

Added a test as well.

https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2080173006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:708:
if (throttle && !mClientManager.isPrerenderingAllowed(uid)) return false;
On 2016/06/21 08:31:26, Yusuf wrote:
> Won't this have the side effect of allowing apps that can prerender on
cellular
> to prerender even if the user has turned off the prerender setting?

This is handled in mayPrerender(), called above.
ClientManager#isPrerenderingAllowed() only deals with throttling and banning.

Added a test to make sure this doesn't change.

[Benoit L, 2016-06-22 08:30:55]

The CQ bit was checked by lizeb@chromium.org

[Benoit L, 2016-06-22 08:30:55]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/2080173006/#ps20001
(title: "Add a test.")

[commit-bot: I haz the power, 2016-06-22 08:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2080173006/20001

[commit-bot: I haz the power, 2016-06-22 09:23:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-22 09:24:46]

Description was changed from

==========
customtabs: Allowing prerendering on cellular also disables throttling.
==========

to

==========
customtabs: Allowing prerendering on cellular also disables throttling.

Committed: https://crrev.com/76d811969eff8f2097fc366dd646faac65667def
Cr-Commit-Position: refs/heads/master@{#401238}
==========

[commit-bot: I haz the power, 2016-06-22 09:24:47]

Patchset 2 (id:??) landed as
https://crrev.com/76d811969eff8f2097fc366dd646faac65667def
Cr-Commit-Position: refs/heads/master@{#401238}