Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2099423002: Convert UtilityProcess to use MojoChild/ShellConnection for the shell handshake. (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gpu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert UtilityProcess to use MojoChild/ShellConnection for the shell handshake. Extracted from: https://codereview.chromium.org/2096643002/ TBR=rockot@chromium.org Committed: https://crrev.com/141b272fb8040d8fc40b44a4a3c197c95894659b Cr-Commit-Position: refs/heads/master@{#402480}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -27 lines) Patch
M content/BUILD.gn View 1 2 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mojo/constants.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/mojo/constants.cc View 1 2 3 1 chunk +9 lines, -4 lines 0 comments Download
M content/browser/mojo/mojo_child_connection.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 7 chunks +17 lines, -12 lines 0 comments Download
M content/content.gyp View 1 2 3 2 chunks +18 lines, -4 lines 0 comments Download
M content/content_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_resources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/BUILD.gn View 1 2 3 1 chunk +9 lines, -3 lines 0 comments Download
A content/public/app/mojo/content_utility_manifest.json View 4 1 chunk +6 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 2104553002 Patch 20001

Dependent Patchsets:

Issue 2109483002 Patch 60001

Messages

Total messages: 13 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099423002/60001
4 years, 5 months ago (2016-06-28 04:11:34 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/88242)
4 years, 5 months ago (2016-06-28 04:25:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099423002/100001
4 years, 5 months ago (2016-06-28 14:08:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/88432)
4 years, 5 months ago (2016-06-28 14:22:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2099423002/120001
4 years, 5 months ago (2016-06-28 14:44:14 UTC) #10
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 5 months ago (2016-06-28 15:47:49 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:50:33 UTC) #13
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/141b272fb8040d8fc40b44a4a3c197c95894659b
Cr-Commit-Position: refs/heads/master@{#402480}

Powered by Google App Engine
This is Rietveld 408576698