Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2109483002: Remove MojoApplication[Host] & ApplicationSetup. (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@u2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MojoApplication[Host] & ApplicationSetup. Extracted from: https://codereview.chromium.org/2096643002/ TBR=rockot@chromium.org Committed: https://crrev.com/756c4e724f9626f989f174408459713bf8f92b84 Cr-Commit-Position: refs/heads/master@{#402484}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -296 lines) Patch
D content/browser/mojo/mojo_application_host.h View 1 chunk +0 lines, -71 lines 0 comments Download
D content/browser/mojo/mojo_application_host.cc View 1 chunk +0 lines, -73 lines 0 comments Download
M content/child/child_thread_impl.h View 4 chunks +0 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 5 chunks +8 lines, -26 lines 0 comments Download
D content/child/mojo/mojo_application.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/child/mojo/mojo_application.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/common/application_setup.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_common_mojo_bindings.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/gpu/gpu_child_thread.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Issue 2099423002 Patch 120001

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2109483002/60001
4 years, 5 months ago (2016-06-28 15:59:20 UTC) #2
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-06-28 16:04:41 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 16:05:56 UTC) #5
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/756c4e724f9626f989f174408459713bf8f92b84
Cr-Commit-Position: refs/heads/master@{#402484}

Powered by Google App Engine
This is Rietveld 408576698