Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2104553002: Migrate GpuProcess to use MojoChild/ShellConnection for the Shell handshake (Closed)

Created:
4 years, 5 months ago by Ben Goodger (Google)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate GpuProcess to use MojoChild/ShellConnection for the Shell handshake Extracted from: https://codereview.chromium.org/2096643002/ TBR=rockot@chromium.org BUG= Committed: https://crrev.com/20c7ccfce55b36fe3ac702243047ea6d121ee6ff Cr-Commit-Position: refs/heads/master@{#402381}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -18 lines) Patch
M content/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 7 chunks +15 lines, -7 lines 0 comments Download
M content/browser/mojo/constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/mojo/constants.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/mojo/mojo_shell_context.cc View 1 6 chunks +32 lines, -0 lines 0 comments Download
M content/content.gyp View 1 chunk +14 lines, -0 lines 0 comments Download
M content/content_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_resources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 4 chunks +24 lines, -9 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A content/public/app/mojo/content_gpu_manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 2099423002 Patch 20001
Issue 2099423002 Patch 40001
Issue 2099423002 Patch 60001
Issue 2099423002 Patch 80001
Issue 2099423002 Patch 100001
Issue 2099423002 Patch 120001

Messages

Total messages: 11 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104553002/20001
4 years, 5 months ago (2016-06-27 20:57:44 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253231)
4 years, 5 months ago (2016-06-28 00:06:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2104553002/20001
4 years, 5 months ago (2016-06-28 01:10:01 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-28 02:23:12 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 02:25:48 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/20c7ccfce55b36fe3ac702243047ea6d121ee6ff
Cr-Commit-Position: refs/heads/master@{#402381}

Powered by Google App Engine
This is Rietveld 408576698