Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M54, then remove it
completely on M56.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
Committed: https://crrev.com/b253a5c54917c2f7bd96f1acf2eeb7d3014a9288
Cr-Commit-Position: refs/heads/master@{#403756}

[Takashi Toyoshima, 2016-06-28 05:30:31]

Description was changed from

==========
WebMIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M53, then remove it
completely on M54.

BUG=599335
==========

to

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M53, then remove it
completely on M54.

BUG=599335
==========

[Takashi Toyoshima, 2016-06-28 05:32:06]

Description was changed from

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M53, then remove it
completely on M54.

BUG=599335
==========

to

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M53, then remove it
completely on M54.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
==========

[Takashi Toyoshima, 2016-06-28 05:32:33]

toyoshim@chromium.org changed reviewers:
+ kouhei@chromium.org

[Takashi Toyoshima, 2016-06-28 05:33:15]

ptal

[Takashi Toyoshima, 2016-06-29 05:14:37]

toyoshim@chromium.org changed reviewers:
+ tkent@chromium.org

[Takashi Toyoshima, 2016-06-29 05:14:38]

+tkent who might be a better person to ask a process for deprecating a property.

[kouhei (in TOK), 2016-06-29 05:25:32]

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webmidi/loopback-receive.html (right):

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webmidi/loopback-receive.html:47:
shouldBeDefined(receivedTimeIsDefined);
This is evaled. See:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/battery-s...

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.cpp (right):

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.cpp:17:
state->getExecutionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource,
InfoMessageLevel, "receivedTime is deprecated and will be removed from
MIDIMessageEvent soon. Use timeStamp instead."));
Please use Deprecation.h infra
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Dep...

[tkent, 2016-06-29 05:26:48]

Do you have a UseCounter for receivedTime?  We can't deprecate anything without
data.
You need to post intent-to-deprecate(-and-remove) to blink-dev.

[Takashi Toyoshima, 2016-06-29 05:34:33]

#8
We do not have a 'receivedTime' specific data, but have a UseCounter for
navigator.requestMIDIAccess() that's the entry point to the Web MIDI API.
Fortunately/Unfortunately, it's <=0.0001%. I will send a Intent to blink-dev.

#6
Thanks. I'll update this CL.

[Takashi Toyoshima, 2016-06-29 08:47:00]

Intent to Deprecate was sent out:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/zOMo62KH8ns

[Takashi Toyoshima, 2016-06-30 10:12:18]

CL was updated to use Deprecation infra and CallWith=ExecutionContext instead of
ScriptState.

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webmidi/loopback-receive.html (right):

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webmidi/loopback-receive.html:47:
shouldBeDefined(receivedTimeIsDefined);
That results in showing actual receivedTime value in the expectation log.
But, the value depends on timing, then expectation won't be matched.
This is a workaround to avoid that problem.

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.cpp (right):

https://codereview.chromium.org/2099213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.cpp:17:
state->getExecutionContext()->addConsoleMessage(ConsoleMessage::create(JSMessageSource,
InfoMessageLevel, "receivedTime is deprecated and will be removed from
MIDIMessageEvent soon. Use timeStamp instead."));
On 2016/06/29 05:25:32, kouhei wrote:
> Please use Deprecation.h infra
>
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/frame/Dep...

Done.

[kouhei (in TOK), 2016-06-30 12:40:45]

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webmidi/loopback-receive.html (right):

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webmidi/loopback-receive.html:47:
shouldBeDefined(receivedTimeIsDefined);
How about shouldBeTrue("e.receivedTime !== undefined")?

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl (right):

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl:39:
[CallWith=ExecutionContext] readonly attribute double receivedTime;
[DeprecateAs=MIDIMessageEventReceivedTime]

[Takashi Toyoshima, 2016-07-01 06:50:23]

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/webmidi/loopback-receive.html (right):

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webmidi/loopback-receive.html:47:
shouldBeDefined(receivedTimeIsDefined);
On 2016/06/30 12:40:45, kouhei wrote:
> How about shouldBeTrue("e.receivedTime !== undefined")?

Done.

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl (right):

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl:39:
[CallWith=ExecutionContext] readonly attribute double receivedTime;
On 2016/06/30 12:40:45, kouhei wrote:
> [DeprecateAs=MIDIMessageEventReceivedTime]

Done.

[tkent, 2016-07-01 06:56:22]

lgtm

https://codereview.chromium.org/2099213002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2099213002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/Deprecation.cpp:390: return
willBeRemoved("MIDIMessageEvent.receivedTime", 54, "5665772797952000");
Now the ToT is 54.  Do you want to remove it in M55 or M56?

[Takashi Toyoshima, 2016-07-01 07:15:00]

Description was changed from

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M53, then remove it
completely on M54.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
==========

to

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M54, then remove it
completely on M56.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
==========

[Takashi Toyoshima, 2016-07-01 07:26:59]

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl (right):

https://codereview.chromium.org/2099213002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl:39:
[CallWith=ExecutionContext] readonly attribute double receivedTime;
https://sites.google.com/a/chromium.org/dev/blink?pli=1#TOC-Launch-Process:-D...

I slightly update this step 4 so that it describes the right class and points
the right file.

Sorry, I should find and read this document first.

https://codereview.chromium.org/2099213002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2099213002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/frame/Deprecation.cpp:390: return
willBeRemoved("MIDIMessageEvent.receivedTime", 54, "5665772797952000");
Oh, branch happened yesterday.

So, I'll change my plan to show deprecation warnings on m54, and remove it m56
as I got a feedback.

[Takashi Toyoshima, 2016-07-01 07:27:15]

toyoshim@chromium.org changed reviewers:
+ isherman@chromium.org

[Takashi Toyoshima, 2016-07-01 07:28:01]

+Ilya though my change in histograms.xml was autogened.

[Ilya Sherman, 2016-07-01 16:39:56]

histograms.xml lgtm

[kouhei (in TOK), 2016-07-04 00:27:08]

lgtm

[Takashi Toyoshima, 2016-07-05 07:02:35]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-07-05 07:02:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
isherman@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2099213002/#ps160001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-05 07:02:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 07:48:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-05 07:48:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Takashi Toyoshima, 2016-07-05 08:28:42]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-07-05 08:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-05 09:03:29]

Description was changed from

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M54, then remove it
completely on M56.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
==========

to

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M54, then remove it
completely on M56.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
==========

[commit-bot: I haz the power, 2016-07-05 09:03:30]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-05 09:05:14]

Description was changed from

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M54, then remove it
completely on M56.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335
==========

to

==========
Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Now that Event::timeStamp is equivalent to DOMHighResTimeStamp,
WG decided to drop DOMHighResTimeStamp receivedTime attribute
from MIDIMessageEvent.

Our plan is to show a deprecate message on M54, then remove it
completely on M56.

This patch changes to show a deprecate message when JavaScript
touches the receivedTime attribute.

BUG=599335

Committed: https://crrev.com/b253a5c54917c2f7bd96f1acf2eeb7d3014a9288
Cr-Commit-Position: refs/heads/master@{#403756}
==========

[commit-bot: I haz the power, 2016-07-05 09:05:16]

Patchset 9 (id:??) landed as
https://crrev.com/b253a5c54917c2f7bd96f1acf2eeb7d3014a9288
Cr-Commit-Position: refs/heads/master@{#403756}