third_party/WebKit/LayoutTests/webmidi/loopback-receive.html - Issue 2099213002: Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webmidi/loopback-receive.html

Issue 2099213002: Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CallWith=ExecutionContext Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/constructors/midi-message-event-constructor-expected.txt ('k') | third_party/WebKit/LayoutTests/webmidi/loopback-receive-expected.txt » ('j') | third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../resources/js-test.js"></script>	4 <script src="../resources/js-test.js"></script>

5 <script src="../http/tests/resources/permissions-helper.js"></script>	5 <script src="../http/tests/resources/permissions-helper.js"></script>

6 </head>	6 </head>

7 <body>	7 <body>

8 <script>	8 <script>

9	9

10 description("Test if midimessage event handler work.");	10 description("Test if midimessage event handler work.");

(...skipping 25 matching lines...) Expand all Loading...
36 [0xf0, 0xf8, 0xf7],	36 [0xf0, 0xf8, 0xf7],

37 ];	37 ];

38	38

39 receiveCount = 0;	39 receiveCount = 0;

40	40

41 function verifyData(e) {	41 function verifyData(e) {

42 debug("receiving data " + receiveCount + ": " + e.data);	42 debug("receiving data " + receiveCount + ": " + e.data);

43 expected = testData[receiveCount];	43 expected = testData[receiveCount];

44 actual = e.data;	44 actual = e.data;

45 shouldBe("actual", "expected");	45 shouldBe("actual", "expected");

	46 receivedTimeIsDefined = e.receivedTime !== undefined;

	47 shouldBeDefined(receivedTimeIsDefined);
	kouhei (in TOK) 2016/06/30 12:40:45 How about shouldBeTrue("e.receivedTime !== undefin How about shouldBeTrue("e.receivedTime !== undefined")? Takashi Toyoshima 2016/07/01 06:50:23 Done. Show quoted text On 2016/06/30 12:40:45, kouhei wrote: > How about shouldBeTrue("e.receivedTime !== undefined")? Done.
46 receiveCount++;	48 receiveCount++;

47 if (receiveCount == testData.length)	49 if (receiveCount == testData.length)

48 e.target.resolve();	50 e.target.resolve();

49 }	51 }

50	52

51 function test(useAddEventListener) {	53 function test(useAddEventListener) {

52 return new Promise(function(resolve, reject) {	54 return new Promise(function(resolve, reject) {

53 debug("running test with useAddEventListener = " + useAddEventListener);	55 debug("running test with useAddEventListener = " + useAddEventListener);

54 navigator.requestMIDIAccess({sysex: true}).then(function (a) {	56 navigator.requestMIDIAccess({sysex: true}).then(function (a) {

55 receiveCount = 0;	57 receiveCount = 0;

(...skipping 15 matching lines...) Expand all Loading...
71 });	73 });

72 }	74 }

73	75

74 PermissionsHelper.setPermission('midi-sysex', 'granted').then(function() {	76 PermissionsHelper.setPermission('midi-sysex', 'granted').then(function() {

75 test(false).then(test.bind(null, true)).then(finishJSTest, finishJSTest);	77 test(false).then(test.bind(null, true)).then(finishJSTest, finishJSTest);

76 });	78 });

77	79

78 </script>	80 </script>

79 </body>	81 </body>

80 </html>	82 </html>

OLD	NEW