third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl - Issue 2099213002: Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime

Side by Side Diff: third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.idl

Issue 2099213002: Web MIDI: prepare to deprecate MIDIMessageEvent::receivedTime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CallWith=ExecutionContext Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/webmidi/loopback-receive.html ('K') | « third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.cpp ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 12 matching lines...) Expand all Loading...
23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT	23 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT

24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,	24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,

25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY	25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY

26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 // http://webaudio.github.io/web-midi-api/#idl-def-MIDIMessageEvent	31 // http://webaudio.github.io/web-midi-api/#idl-def-MIDIMessageEvent

32	32

	33 // TODO(toyoshim): Remove ConstructorCallWith=ExecutionContext and receivedTime.

	34 // See https://github.com/WebAudio/web-midi-api/issues/145 and crbug.com/599335.

33 [	35 [

34 Constructor(DOMString type, optional MIDIMessageEventInit eventInitDict),	36 Constructor(DOMString type, optional MIDIMessageEventInit eventInitDict),

	37 ConstructorCallWith=ExecutionContext,

35 ] interface MIDIMessageEvent : Event {	38 ] interface MIDIMessageEvent : Event {

36 readonly attribute double receivedTime;	39 [CallWith=ExecutionContext] readonly attribute double receivedTime;
	kouhei (in TOK) 2016/06/30 12:40:45 [DeprecateAs=MIDIMessageEventReceivedTime] [DeprecateAs=MIDIMessageEventReceivedTime] Takashi Toyoshima 2016/07/01 06:50:23 Done. Show quoted text On 2016/06/30 12:40:45, kouhei wrote: > [DeprecateAs=MIDIMessageEventReceivedTime] Done. Takashi Toyoshima 2016/07/01 07:26:59 https://sites.google.com/a/chromium.org/dev/blink? https://sites.google.com/a/chromium.org/dev/blink?pli=1#TOC-Launch-Process:-D... I slightly update this step 4 so that it describes the right class and points the right file. Sorry, I should find and read this document first.
37 readonly attribute Uint8Array data;	40 readonly attribute Uint8Array data;

38 };	41 };

OLD	NEW